929673 - rename some variables/functions that use -moz- CSS prefixes in their names

Status: RESOLVED FIXED

(Core :: Web Painting, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

There's some code dating from bug 706179 and from bug 435293 that uses "mozOrigin" or "mozTransformOrigin" where it should be using "transformOrigin" as a variable name.  We shouldn't be putting CSS prefixes in variable names -- and we especially shouldn't be removing the important part of the variable name and replacing it with the prefix (mozOrigin for the value of transform-origin).

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Patch 1: Rename mozOrigin to transformOrigin to avoid use of deprecated CSS prefixes in variable names.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Patch 2: Rename mToMozOrigin to mToTransformOrigin to avoid use of deprecated CSS prefixes in variable names.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Patch 3: Rename GetDeltaToMoz{Transform,Perspective}Origin to remove the Moz to avoid use of deprecated CSS prefixes in variable names.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(For the record, I got here via bug 921317 comment 23.)

Comment 5

[David Zbarsky (:dzbarsky)]

Comment on attachment 820566 [details] [diff] [review]
Patch 3:  Rename GetDeltaToMoz{Transform,Perspective}Origin to remove the Moz to avoid use of deprecated CSS prefixes in variable names.

Review of attachment 820566 [details] [diff] [review]:
-----------------------------------------------------------------

After these patches we still have a gMozTransformSubpropTable at http://mxr.mozilla.org/mozilla-central/source/layout/style/nsCSSProps.cpp#2440 that seems to be unused.  Want to get rid of that too?

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to David Zbarsky (:dzbarsky) from comment #5)
> After these patches we still have a gMozTransformSubpropTable at
> http://mxr.mozilla.org/mozilla-central/source/layout/style/nsCSSProps.
> cpp#2440 that seems to be unused.  Want to get rid of that too?

No; it's used (via CSS_PROP_SHORTHAND in nsCSSPropList.h), and it's part of what makes -moz-transform an alias for transform.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/66e24e999199
https://hg.mozilla.org/integration/mozilla-inbound/rev/58cbe73b3920
https://hg.mozilla.org/integration/mozilla-inbound/rev/41496e6e589d

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/66e24e999199
https://hg.mozilla.org/mozilla-central/rev/58cbe73b3920
https://hg.mozilla.org/mozilla-central/rev/41496e6e589d