929689 - NewTabUtils.jsm js exceptions

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Firefox Start, defect, P2)

Description

[Allison Naaktgeboren :ally]

[JavaScript Error: "[Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getBoolPref]"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame :: resource://gre/modules/NewTabUtils.jsm :: <TOP_LEVEL> :: line 223"  data: no]" {file: "resource://gre/modules/NewTabUtils.jsm" line: 223}]
[JavaScript Error: "Not a number" {file: "resource://gre/modules/PlacesDBUtils.jsm" line: 975}]
[JavaScript Error: "[Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getBoolPref]"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame :: resource://gre/modules/NewTabUtils.jsm :: <TOP_LEVEL> :: line 223"  data: no]" {file: "resource://gre/modules/NewTabUtils.jsm" line: 223}]

m-c from monday, these were not here last week. appeared upon startup, not a new profile.

Comment 1

[Matt Brubeck (:mbrubeck)]

The NewTabUtils errors are trying to read the "browser.newtabpage.enabled" pref.  We may want to add this to metro.js:

 pref("browser.newtabpage.enabled", true);

(Or should it be false?)

Comment 2

[Jim Mathies [:jimm]]

I think we want this set to true so our thumbnails update - 

http://mxr.mozilla.org/mozilla-central/ident?i=AllPages&tree=mozilla-central&filter=

Comment 3

[Jim Mathies [:jimm]]

Attachment: fix

I've been doing update testing over on oak, and I keep seeing this in the console. Adding this pref solves the problem and doesn't appear to mess with our about:start thumbnails in any way.

Comment 4

[Jim Mathies [:jimm]]

Attachment: export

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/1c7a9d75142f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1c7a9d75142f

Comment 7

[Manuela Muntean [Away]]

Could anyone please give guidance in order for the QA to verify this?

Comment 8

[Jim Mathies [:jimm]]

(In reply to Manuela Muntean [:Manuela] [QA] from comment #7)
> Could anyone please give guidance in order for the QA to verify this?

Open the browser, hit ctrl-shift-j, wait ten seconds. you shouldn't see any exceptions in NewTabUtils code in the console.

Comment 9

[Manuela Muntean [Away]]

(In reply to Jim Mathies [:jimm] from comment #8)
> (In reply to Manuela Muntean [:Manuela] [QA] from comment #7)
> > Could anyone please give guidance in order for the QA to verify this?
> 
> Open the browser, hit ctrl-shift-j, wait ten seconds. you shouldn't see any
> exceptions in NewTabUtils code in the console.

Verified as fixed with latest Nightly on Win 8 64-bit, for iteration IT-30C-29A-28B.1 (it #24)