Closed Bug 929750 Opened 11 years ago Closed 11 years ago

(OSX 10.6) TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_overflowScroll.js | Scrolled one page of tabs with a double click - Got 36, expected 136

Categories

(Firefox :: Tabbed Browser, defect)

Product:
Firefox
Component:
Tabbed Browser
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 28

People

(Reporter: jaws, Assigned: Gijs)

References

Details

(Whiteboard: [Australis:P1][Australis:M9])

Attachments

(1 file, 1 obsolete file)

fix (literal) edge case in overflow scroll test,
1.81 KB, patch
jaws
: review+
Details | Diff | Splinter Review 
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_overflowScroll.js | Scrolled one page of tabs with a double click - Got 36, expected 136

Introduced by bug 875180.
(In reply to Jared Wein [:jaws] from comment #1)
> https://tbpl.mozilla.org/?tree=Try&rev=9761253031af

Because this still failed, I decided to just push a logging cset so we can see what's going on on 10.6 compared to 10.7/10.8/win32/linux (I forgot linux64, but I guess this will give us enough to go on):

https://tbpl.mozilla.org/?tree=Try&rev=60c2d9f36898
So, the first number is the value passed to _elementFromPoint. The second is the left and the third the right side of the bounding box of the element that was found this way (NB: does *not* include the tab margin). The last number (with 'moving ') is the width of the scrollbox. The second line has the position of the element we found, and the position of the scrollbox.

Notes:
- All the positions are relative to the topleft of the window.
- You can see the element in each successful test ends up exactly (width of scrollbox) pixels to the right of where it was before.
- 10.7 and 10.8 are identical
- 10.6 *in the test code* finds an item with its right bounding box edge on -849, which ends up being the item before the one the actual code selects (ie, the actual code picked the element with the left edge of the bounding box on that pixel offset. I'm not sure why without further investigation, but I'm getting ill and need to go lie down.

Linux:
browser_overflowScroll.js | -929: -1013, -913 (moving 1001)
browser_overflowScroll.js | element now at 72, scrollbox at 72

Mac.6:
browser_overflowScroll.js | -849: -949, -849 (moving 985)
browser_overflowScroll.js | element now at 36, scrollbox at 136

Mac 7:
browser_overflowScroll.js | -835: -852, -752 (moving 968)
browser_overflowScroll.js | element now at 133, scrollbox at 133


Mac.8:
browser_overflowScroll.js | -835: -852, -752 (moving 968)
browser_overflowScroll.js | element now at 133, scrollbox at 133

WinXP:
browser_overflowScroll.js | -898: -912, -812 (moving 971)
browser_overflowScroll.js | element now at 73, scrollbox at 73

Win 7:
browser_overflowScroll.js | -612: -613, -513 (moving 684)
browser_overflowScroll.js | element now at 72, scrollbox at 72

Win 8:
browser_overflowScroll.js | -852: -913, -813 (moving 924)
browser_overflowScroll.js | element now at 72, scrollbox at 72
Whiteboard: [Australis:P1][Australis:M9]
This works on my machine.
Attachment #821163 - Flags: review?(jaws)
Assignee: jaws → gijskruitbosch+bugs
Sans cruft
Attachment #821165 - Flags: review?(jaws)
Attachment #821163 - Attachment is obsolete: true
Attachment #821163 - Flags: review?(jaws)
Comment on attachment 821163 [details] [diff] [review]
fix (literal) edge case in overflow scroll test,

Review of attachment 821163 [details] [diff] [review]:
-----------------------------------------------------------------

Revert the scrollbox.xml changes and you have r+
Attachment #821163 - Attachment is obsolete: false
Attachment #821165 - Flags: review?(jaws) → review+
Attachment #821163 - Attachment is obsolete: true
https://hg.mozilla.org/projects/ux/rev/3b21a11c0b76
Whiteboard: [Australis:P1][Australis:M9] → [Australis:P1][Australis:M9][fixed-in-ux]
I think all the extant builds before my fix from yesterday are starred now, so removing the keyword.
Keywords: intermittent-failure
https://hg.mozilla.org/mozilla-central/rev/3b21a11c0b76
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P1][Australis:M9][fixed-in-ux] → [Australis:P1][Australis:M9]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: