Closed
Bug 929784
Opened 11 years ago
Closed 10 years ago
In gloda facet view, long email addresses can push content off-screen
Categories
(Thunderbird :: Search, defect)
Thunderbird
Search
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 29.0
People
(Reporter: squib, Assigned: squib)
Details
Attachments
(2 files)
3.65 KB,
patch
|
mkmelin
:
review+
jsbruner
:
ui-review+
|
Details | Diff | Splinter Review |
377 bytes,
text/plain
|
Details |
In the gloda facet view, the list of facets on the left can get really wide if there's a long email address in there (I get some of these with Github mails). We should truncate them to prevent this. One downside is that we can't easily show a tooltip for the truncated addresses, since the items are anonymous HTML created by XBL, and the XUL tooltip listener doesn't look at anonymous content. You can still see the whole address by clicking on the item, though.
Assignee | ||
Comment 1•10 years ago
|
||
This adds some simple CSS to truncate long items in the facet list (the left hand side of the gloda search), and then some clever JS to show a tooltip. I could make the tooltips only show when the list item actually overflows, but I'm not sure we want that.
Attachment #8362799 -
Flags: ui-review?(josiah)
Attachment #8362799 -
Flags: review?(mkmelin+mozilla)
Comment 2•10 years ago
|
||
Do you mind forwarding me an email with an example of a long account name? I don't currently have one.
Assignee | ||
Comment 3•10 years ago
|
||
Here's a test email that reproduces the issue for me. Just save it and drag it into a folder (and then maybe wait a few seconds for gloda to index it).
Assignee | ||
Updated•10 years ago
|
Attachment #8363296 -
Attachment mime type: application/x-extension-eml → text/plain
Comment 4•10 years ago
|
||
Comment on attachment 8362799 [details] [diff] [review] Truncate long items in the facet list Review of attachment 8362799 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. Thanks!
Attachment #8362799 -
Flags: ui-review?(josiah) → ui-review+
Comment 5•10 years ago
|
||
Comment on attachment 8362799 [details] [diff] [review] Truncate long items in the facet list Review of attachment 8362799 [details] [diff] [review]: ----------------------------------------------------------------- Yup, this seems to work. r=mkmelin
Attachment #8362799 -
Flags: review?(mkmelin+mozilla) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Landed: https://hg.mozilla.org/comm-central/rev/887255521bff
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 29.0
You need to log in
before you can comment on or make changes to this bug.
Description
•