929784 - In gloda facet view, long email addresses can push content off-screen

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Jim Porter (:squib)]

In the gloda facet view, the list of facets on the left can get really wide if there's a long email address in there (I get some of these with Github mails). We should truncate them to prevent this.

One downside is that we can't easily show a tooltip for the truncated addresses, since the items are anonymous HTML created by XBL, and the XUL tooltip listener doesn't look at anonymous content. You can still see the whole address by clicking on the item, though.

Comment 1

[Jim Porter (:squib)]

Attachment: Truncate long items in the facet list

This adds some simple CSS to truncate long items in the facet list (the left hand side of the gloda search), and then some clever JS to show a tooltip. I could make the tooltips only show when the list item actually overflows, but I'm not sure we want that.

Comment 2

[Josiah Bruner [:jsbruner]]

Do you mind forwarding me an email with an example of a long account name? I don't currently have one.

Comment 3

[Jim Porter (:squib)]

Attachment: A test email

Here's a test email that reproduces the issue for me. Just save it and drag it into a folder (and then maybe wait a few seconds for gloda to index it).

Comment 4

[Josiah Bruner [:jsbruner]]

Comment on attachment 8362799 [details] [diff] [review]
Truncate long items in the facet list

Review of attachment 8362799 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks!

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 8362799 [details] [diff] [review]
Truncate long items in the facet list

Review of attachment 8362799 [details] [diff] [review]:
-----------------------------------------------------------------

Yup, this seems to work. r=mkmelin

Comment 6

[Jim Porter (:squib)]

Landed: https://hg.mozilla.org/comm-central/rev/887255521bff