Closed Bug 92979 Opened 23 years ago Closed 11 years ago

Remove unused parameters in nsNetUtil.h methods

Categories

(Core :: Networking, defect)

Product:
Core
Component:
Networking
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla22

People

(Reporter: Brade, Assigned: Cykesiopka)

Details

(Keywords: helpwanted)

Attachments

(1 file)

Remove unused parameters in nsNetUtil.h methods v1
6.59 KB, patch
Biesinger
: review+
Details | Diff | Splinter Review 
NS_NewPostDataStream's last parameter is an nsIIOService but that is never used 
in the implementation.  It should be.
Target Milestone: --- → Future
the parameter is unused because it is not needed by the implementation of the
function.  in the past that may not have been the case.  at any rate, we can
safely remove it now.

LXR says we'd need to touch 2 callsites:
http://lxr.mozilla.org/seamonkey/search?string=NS_NewPostDataStream
Severity: normal → trivial
Keywords: helpwanted
mass reassigning to nobody.
Assignee: dougt → nobody
This patch touches on a few other additional methods where there are unused parameters... I can adjust the bug summary, or limit my patch to just NS_NewPostDataStream(), whichever is better...
Attachment #722035 - Flags: review?(cbiesinger)
Attachment #722035 - Flags: review?(cbiesinger) → review+
Assignee: nobody → cykesiopka
Keywords: checkin-needed
Target Milestone: Future → ---
Summary: NS_NewPostDataStream doesn't use nsIIOService → Remove unused parameters in nsNetUtil.h methods
https://hg.mozilla.org/mozilla-central/rev/f3a0fe13a11a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: