929813 - [Settings] Split up about.js and add declaration to opt-in to lazy loading

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Kevin Grandon :kgrandon]

For this bug we should create a way for a panel to decide whether or not to load it's children as dependencies. In addition we should split up about.js so it doesn't load all of the subpanel content.

Once we have this method, we can add additional blockers to the parent bug and anyone can take them.

Comment 1

[Arthur Chen [:arthurcc][inactive after 6/30]]

There are requests of supporting inline activity in settings app. One of the reasons that blocks the support is that we are not able to launch a sub panel without the root panel and settings.js loaded. Which results in that users must see the root panel appears before they are brought to the panel specified in the web activity. I was wondering can we take this into consideration when designing the way of lazy loading?

Comment 2

[Kevin Grandon :kgrandon]

(In reply to Arthur Chen [:arthurcc] from comment #1)
> There are requests of supporting inline activity in settings app. One of the
> reasons that blocks the support is that we are not able to launch a sub
> panel without the root panel and settings.js loaded. Which results in that
> users must see the root panel appears before they are brought to the panel
> specified in the web activity. I was wondering can we take this into
> consideration when designing the way of lazy loading?

Yeah - looks like there are several places where we do this already. We show the root page, then navigate to the proper panel. This experience kind of sucks =/

I'd love to optimize that as well but I feel that's going to be more of a haida optimization to come around 1.5ish. Unfortunately I don't think the work here will fix that, but it is necessary to get to that state!

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Agree, the work here is the first step toward the goal.

And a random thought is that there are cases in which same objects are used across multiple panels. We may need a way for panels to manage these objects in terms of specifying and requiring the objects.

Comment 4

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 821519 [details] [review]
Github pull request

Hi Kaze - I may have a few patches coming for this settings work. Would you like to review them, or maybe perhaps have Arthur review them? I'm not sure who has more time these days. Thanks!

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 821519 [details] [review]
Github pull request

Looks good to me and thanks for the patch. r=me with the comments addressed.

Comment 7

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#13104

Comment 8

[Kevin Grandon :kgrandon]

Landed in master: https://github.com/mozilla-b2g/gaia/commit/9a1d3b0b6e8ccaf25f55e4706a4d73f1287603f7

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 822597 [details] [review]
mozilla-b2g:master PR#13104

Oops - shepherd commit attached to wrong bug.