debug jit-tests/basic/spread-call-maxarg.js times out in jit_tests.py --tbpl run

RESOLVED FIXED in mozilla27

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: luke, Assigned: luke)

Tracking

unspecified
mozilla27
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Posted patch fix-slow-testSplinter Review
On a fast multi-core machine, spread-call-maxarg.js regularly times out for me when I run with --tbpl.  Running jit_tests.py single-threaded, the test completes but, e.g.,
  jit_test.py --args='--no-baseline --no-ion' ../d/js spread-call-maxarg
takes 1 minute, 37 seconds.

It looks like Wingo already ran into this test running slowly on debug ASAN builds and disabled it in that case.  I propose disabling it for all debug builds.  Opt builds take only a few seconds.
Attachment #820743 - Flags: review?(jorendorff)
Summary: jit-tests/basic/spread-call-maxarg.js times out in jit_tests.py --tbpl run → debug jit-tests/basic/spread-call-maxarg.js times out in jit_tests.py --tbpl run
Bummer, this.

Fixing it properly is bug 923028, though GGC will help.  It would be nice for the test to be enabled for optimized builds with assertions enabled (-g -O2 -DDEBUG), though; here such a build completes the test you mention in 0.1s.

Andy
Comment on attachment 820743 [details] [diff] [review]
fix-slow-test

Review of attachment 820743 [details] [diff] [review]:
-----------------------------------------------------------------

Ugh.
Attachment #820743 - Flags: review?(jorendorff) → review+
https://hg.mozilla.org/mozilla-central/rev/27e42f27f03a
Assignee: nobody → luke
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.