Make the shader editor UI responsive when docked to the side

VERIFIED FIXED in Firefox 27

Status

defect
VERIFIED FIXED
6 years ago
4 months ago

People

(Reporter: vporof, Assigned: vporof)

Tracking

unspecified
Firefox 27
Dependency tree / graph

Firefox Tracking Flags

(firefox26 unaffected, firefox27 verified, firefox28 verified)

Details

Attachments

(2 attachments)

No description provided.
Depends on: 910955
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #820876 - Flags: review?(dcamp)
Looks like this.
Comment on attachment 820876 [details] [diff] [review]
webgl-responsive.patch

Review of attachment 820876 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/shadereditor/shadereditor.js
@@ +186,5 @@
>      }
> +
> +    // Prevent this container from growing indefinitely in height when the
> +    // toolbox is docked to the side.
> +    if (gToolbox.hostType == "side" && this.itemCount == SHADERS_AUTOGROW_ITEMS) {

Can you explain real quick why this is needed?
(In reply to Dave Camp (:dcamp) from comment #3)
> 
> Can you explain real quick why this is needed?

If it wasn't there, as more and more programs are added, the list's height grows as much as allowed by the max-height value specified in the CSS. That's not very nice, since filling up all the available height is an extreme, not an optimum, so I halt it by setting a height attribute after a few items.
Reasonable?
Flags: needinfo?(dcamp)
Attachment #820876 - Flags: review?(dcamp) → review+
Component: Developer Tools → Developer Tools: WebGL Shader Editor
https://hg.mozilla.org/mozilla-central/rev/0f10e96cbad1
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
Flags: needinfo?(dcamp)
Keywords: verifyme
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:26.0) Gecko/20100101 Firefox/26.0
Mozilla/5.0 (Windows NT 6.2; rv:26.0) Gecko/20100101 Firefox/26.0
Mozilla/5.0 (X11; Linux i686; rv:26.0) Gecko/20100101 Firefox/26.0

Verified as fixed on latest Aurora (buildID: 20131111004004) and latest Nightly (buildID: 20131111030205).
Status: RESOLVED → VERIFIED
Keywords: verifyme
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.