929916 - Make the shader editor UI responsive when docked to the side

Status: VERIFIED FIXED

(DevTools Graveyard :: WebGL Shader Editor, defect)

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: webgl-responsive.patch

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: Screen Shot 2013-10-23 at 11.49.39 AM.png

Looks like this.

Comment 3

[Dave Camp (:dcamp)]

Comment on attachment 820876 [details] [diff] [review]
webgl-responsive.patch

Review of attachment 820876 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/shadereditor/shadereditor.js
@@ +186,5 @@
>      }
> +
> +    // Prevent this container from growing indefinitely in height when the
> +    // toolbox is docked to the side.
> +    if (gToolbox.hostType == "side" && this.itemCount == SHADERS_AUTOGROW_ITEMS) {

Can you explain real quick why this is needed?

Comment 4

[Victor Porof [:vporof][:vp]]

(In reply to Dave Camp (:dcamp) from comment #3)
> 
> Can you explain real quick why this is needed?

If it wasn't there, as more and more programs are added, the list's height grows as much as allowed by the max-height value specified in the CSS. That's not very nice, since filling up all the available height is an extreme, not an optimum, so I halt it by setting a height attribute after a few items.

Comment 5

[Victor Porof [:vporof][:vp]]

Reasonable?

Comment 6

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0f10e96cbad1

Comment 7

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0f10e96cbad1

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/0f10e96cbad1

Comment 9

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0f10e96cbad

Comment 10

[Bogdan Maris, Desktop Test Engineering]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:26.0) Gecko/20100101 Firefox/26.0
Mozilla/5.0 (Windows NT 6.2; rv:26.0) Gecko/20100101 Firefox/26.0
Mozilla/5.0 (X11; Linux i686; rv:26.0) Gecko/20100101 Firefox/26.0

Verified as fixed on latest Aurora (buildID: 20131111004004) and latest Nightly (buildID: 20131111030205).