929917 - Create gaia test_app to exercise DOM API for Firefox Accounts

Status: RESOLVED FIXED

(Core Graveyard :: Identity, defect)

Description

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

A test app, like the navigator.mozId tests, that exercises the Firefox Accounts code path will be useful for developer testing as well as QA.

Comment 1

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

To be specific, I mean a gaia test_app

Comment 2

[James Bonacci [:jbonacci]]

Awesome.

Comment 3

[Edwin Wong [:edwong]]

O.o - fun

Comment 4

[Sam Penrose]

Attachment: 929917.untested.patch

Here's a small addition to the nav.mozID screen in the "UI Tests" test app that sends the wantIssuer parameter to watch(). Can't verify it works due to a gecko crash issue.

Comment 5

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Attachment: 929917-fxa-test-app.patch

Rebased over gaia master

Github link: https://github.com/jedp/gaia/tree/929917-fxa-test-app

Comment 6

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

This never landed in gaia, did it?

Comment 7

[Sam Penrose]

I think so: https://github.com/mozilla-b2g/gaia/tree/master/test_apps/test-fxa-client Amirite?

Comment 8

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Ah - that's the IAC API, not the DOM API.  We still want the UI Tests to exercise the DOM API.

Reopening.  I'll tidy up my patch.  Sorry this got lost in the shuffle.

Comment 9

[Fernando Jiménez Moreno [:ferjm]]

(In reply to Jed Parsons (use needinfo, please) [:jedp, :jparsons] from comment #6)
> This never landed in gaia, did it?

Yes, it landed, but I reverted it cause it was making UI test automation to fail. We can land it again after bug 929386.

Comment 10

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Attachment: Gaia UI Test app for Firefox Accounts DOM API

Sam, I'm happy to take this bug, if you have no objections.

I've added a separate gaia test app for the fxa DOM API tests.  I think it will be better to keep the Persona and Firefox Accounts test apps separate.

I think we should use this or something like it instead of whatever we had before.

Comment 11

[Sam Penrose]

Fantastic; thanks Jed!

Comment 13

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Comment on attachment 8389549 [details]
Gaia UI Test app for Firefox Accounts DOM API

We should just get something landed that we can start using.

Fernando, Sam, this patch makes a simple gaia test app for fxa.

You can login, logout, cancel login flow, and verify that watch sends a silent assertion (if you rig your test right)

I copied the css from what somebody added to the other identity ui test app.  I have no personal views on the layout, but i thought it would be best to keep the same element structure and ids used in other automated tests.

Comment 14

[Sam Penrose]

Comment on attachment 8389549 [details]
Gaia UI Test app for Firefox Accounts DOM API

Thanks for adding this -- very helpful and looks good. Nits picked in PR.

Comment 15

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Thanks, Sam.  Fixed and rebased.

Comment 16

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8389549 [details]
Gaia UI Test app for Firefox Accounts DOM API

Thanks Jed. Make sure that Travis is happy with this patch before landing, please. Also, AFAIK there are no peers for the UI Test app, but I'd like Zac to take an additional look at the patch if possible as he is very familiar with this app.

Comment 17

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Thanks, Fernando.  That makes good sense.

Yes, I'll watch travis.  There may have been some bad effect on the persona marionette tests because this patch changes the titles of some elements (though not their ids).

Comment 18

[Zac C (:zac)]

Yes it looks like you need to change the locator here:
https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/apps/ui_tests/app.py#L17

As there is no ID on the element we've had to use Link text to match it which often leads to these kinds of issues.

Comment 19

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Thanks, Zac.  Since these the tests and gaia are in two separate repos, would it make sense for me to:

1) add IDs to the elements as they are now, and commit to gaia
2) update gaia-ui-tests to select by ID, and commit
3) then update gaia again to add the new fxa component, with changed titles?

Comment 20

[Zac C (:zac)]

The tests are in the same repo.
I don't mind if you use LINK_TEXT to locate the button but seeing as it's all in one patch and it's got to change anyway it'sa nice chance to add an ID in the app and the test and future proof it a bit :)

Comment 21

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Updated PR according to comment 20

Comment 22

[Zac C (:zac)]

Comment on attachment 8389549 [details]
Gaia UI Test app for Firefox Accounts DOM API

Sorry guys I did not see that you'd update this pull request! Hope I wasn't holding you up.

r+ from me, good solution :)

Comment 23

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Thanks for the review, Zac!  I appreciate your having caught it.  I intended to ask for your review directly but in your perspicacity you beat me to it.

Travis is happy with the changes, so I've gone ahead and merged this.

I've opened Bug 986775 for us to write some basic marionette tests.

This is what I wanted when I opened this bug, so I'm going to go ahead and close it.  Please re-open if you think I'm mistaken.

Cheers,
j