930020 - Allow CSS pseudo-elements to be hidden from content

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jonathan Watt [:jwatt]]

I need to allow CSS pseudo-elements to be hidden from content in order to fix bug 930010. That should be a case of adding an mUnsafeRulesEnabled check to CSSParserImpl::ParsePseudoSelector.

Comment 1

[Cameron McCormack (:heycam)]

Attachment: Part 1: Add a flag to pseudo-elements to say whether they are exposed to content.

Comment 2

[Cameron McCormack (:heycam)]

Attachment: Part 2: Use flag to hide <input type=number> pseudo-elements from content.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8339663 [details] [diff] [review]
Part 1: Add a flag to pseudo-elements to say whether they are exposed to content.

>+    return PseudoElementIsChromeOnly(aType, CSS_PSEUDO_ELEMENT_IS_CHROME_ONLY);

That should be calling PseudoElementHasFlags, right?  Did this compile?

r=me with that fixed.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8339665 [details] [diff] [review]
Part 2: Use flag to hide <input type=number> pseudo-elements from content.

r=me

Comment 5

[Cameron McCormack (:heycam)]

(In reply to Boris Zbarsky [:bz] from comment #3)
> >+    return PseudoElementIsChromeOnly(aType, CSS_PSEUDO_ELEMENT_IS_CHROME_ONLY);
> 
> That should be calling PseudoElementHasFlags, right?  Did this compile?

Yeah, had it fixed locally, thanks.

Comment 6

[Cameron McCormack (:heycam)]

https://tbpl.mozilla.org/?tree=Try&rev=1510c6f79751

Comment 7

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bb48b3653117
https://hg.mozilla.org/integration/mozilla-inbound/rev/f01c4abf8581

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bb48b3653117
https://hg.mozilla.org/mozilla-central/rev/f01c4abf8581