Closed
Bug 930025
Opened 9 years ago
Closed 9 years ago
B2G emulator unittests don't check for crashes in all the places they should
Categories
(Testing :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla27
People
(Reporter: ahal, Assigned: ahal)
References
Details
Attachments
(2 files)
4.89 KB,
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
10.32 KB,
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
I'm not sure if this was a regression, or was always the case. Either way, we are missing some calls to "check_for_crashes".
Assignee | ||
Comment 1•9 years ago
|
||
I think it's easier to pass the symbols path in as an instance variable as it's state will probably never change. I also moved the core crash checking method to the Runner class, RemoteRunner now wraps it sets up the local_dump_dir.
Attachment #821067 -
Flags: review?(jgriffin)
Assignee | ||
Comment 2•9 years ago
|
||
Does the same symbols path refactor. Checks for crashes if an exception occurs in wait_for_system_message or during a mochitest run.
Attachment #821070 -
Flags: review?(jgriffin)
Assignee | ||
Comment 3•9 years ago
|
||
I did a pair of try runs for those patches: https://tbpl.mozilla.org/?tree=Try&rev=11e95198fc2d https://tbpl.mozilla.org/?tree=Try&rev=fc5ec202edf5
Comment 4•9 years ago
|
||
Comment on attachment 821067 [details] [diff] [review] Patch 1.0 (mozbase) - refactor crash checking, check on timeout Review of attachment 821067 [details] [diff] [review]: ----------------------------------------------------------------- lgtm
Attachment #821067 -
Flags: review?(jgriffin) → review+
Updated•9 years ago
|
Attachment #821070 -
Flags: review?(jgriffin) → review+
Assignee | ||
Comment 5•9 years ago
|
||
https://github.com/mozilla/mozbase/commit/e1270072539fc55379ce8a7668ada1843537aadf https://hg.mozilla.org/integration/mozilla-inbound/rev/dfb15cca5df4 Note the inbound push also cherry picks the mozrunner changes, which are needed for the mochitest change to work.
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/dfb15cca5df4
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•