930025 - B2G emulator unittests don't check for crashes in all the places they should

Status: RESOLVED FIXED

Description

[Andrew Halberstadt [:ahal]]

I'm not sure if this was a regression, or was always the case. Either way, we are missing some calls to "check_for_crashes".

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.0 (mozbase) - refactor crash checking, check on timeout

I think it's easier to pass the symbols path in as an instance variable as it's state will probably never change.

I also moved the core crash checking method to the Runner class, RemoteRunner now wraps it sets up the local_dump_dir.

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.0 (m-c) - check if exception on startup or during run

Does the same symbols path refactor. Checks for crashes if an exception occurs in wait_for_system_message or during a mochitest run.

Comment 3

[Andrew Halberstadt [:ahal]]

I did a pair of try runs for those patches:
https://tbpl.mozilla.org/?tree=Try&rev=11e95198fc2d
https://tbpl.mozilla.org/?tree=Try&rev=fc5ec202edf5

Comment 4

[Jonathan Griffin (:jgriffin)]

Comment on attachment 821067 [details] [diff] [review]
Patch 1.0 (mozbase) - refactor crash checking, check on timeout

Review of attachment 821067 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 5

[Andrew Halberstadt [:ahal]]

https://github.com/mozilla/mozbase/commit/e1270072539fc55379ce8a7668ada1843537aadf
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfb15cca5df4

Note the inbound push also cherry picks the mozrunner changes, which are needed for the mochitest change to work.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dfb15cca5df4