B2G emulator unittests don't check for crashes in all the places they should

RESOLVED FIXED in mozilla27

Status

defect
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: ahal, Assigned: ahal)

Tracking

unspecified
mozilla27
ARM
Gonk (Firefox OS)
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

I'm not sure if this was a regression, or was always the case. Either way, we are missing some calls to "check_for_crashes".
I think it's easier to pass the symbols path in as an instance variable as it's state will probably never change.

I also moved the core crash checking method to the Runner class, RemoteRunner now wraps it sets up the local_dump_dir.
Attachment #821067 - Flags: review?(jgriffin)
Does the same symbols path refactor. Checks for crashes if an exception occurs in wait_for_system_message or during a mochitest run.
Attachment #821070 - Flags: review?(jgriffin)
Comment on attachment 821067 [details] [diff] [review]
Patch 1.0 (mozbase) - refactor crash checking, check on timeout

Review of attachment 821067 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #821067 - Flags: review?(jgriffin) → review+
Attachment #821070 - Flags: review?(jgriffin) → review+
https://github.com/mozilla/mozbase/commit/e1270072539fc55379ce8a7668ada1843537aadf
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfb15cca5df4

Note the inbound push also cherry picks the mozrunner changes, which are needed for the mochitest change to work.
https://hg.mozilla.org/mozilla-central/rev/dfb15cca5df4
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Depends on: 1027607
You need to log in before you can comment on or make changes to this bug.