93005 - "http://" needs to be prefixed in the "Attach a Web Page" dialog in compose window.

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[[e-mail] (gone - use [e-mail] instead)]

Build ID:  2001-07-31-03 (Windows 2000)

Summary: "http://" needs to be prefixed in the "Attach a Web Page" dialog in
compose window.

Steps to Reproduce:

1.  Start the compose window.
2.  File | Attach Web Page
3.  Look at the textfield in that new dialog.

Actual Results:

Currently, we are filling it with a null value: var dialog = "";

Expected Results:

According to the spec:
http://www.mozilla.org/mailnews/specs/compose/#Attachments, we should be
pre-filling "http://" for the following reasons (quoted from the spec):

The default text "http://" appears in the "Web Page (URL):" text entry field.
This gives users a better idea what is expected in this text field and it is
also very likely that the desired URL will start this way, so it saves them some
time.

NOTE:  I've got what I think is a fix in my local tree.  When Brendan's fastload
bustage is cleared for Win32, I'll text the fix (build chrome), and then if it's
good, I'll post the patch for review/sr.

Comment 1

[Jean-Francois Ducarroz]

Also, if we are going to do some work on this dialog, we should try to use a url
autocomplete widget.

Comment 2

[[e-mail] (gone - use [e-mail] instead)]

Yeah, that should be filed seperately though.  I was actually planning on fixing
this one, so when my build finishes and I have tested my code, I'll re-assign
and seek reviews.

Comment 3

[[e-mail] (gone - use [e-mail] instead)]

Okay, cool, my fix works.  All I did was add "http://" to msgComposeCommands.js
line 1679:

function AttachPage()
{
    if (promptService)
    {
        var result = {value:"http://"};
        if (promptService.prompt(
        	window,
        	gComposeMsgsBundle.getString("attachPageDlogTitle"),
        	gComposeMsgsBundle.getString("attachPageDlogMessage"),
            result,
        	null,
        	{value:0}))
        {
			AddAttachment(result.value, null);
        }
    }
}
A diff of that file wouldn't be easy to read, since my tree has all of Blake's
message compose changes in it.  I've tested this thoroughly.

Comment 4

[varada]

r=varada

Comment 5

[(not reading, please use [e-mail] instead)]

Attachment: is this your patch?

Comment 6

[(not reading, please use [e-mail] instead)]

Attachment: sorry, this is your patch.

Comment 7

[(not reading, please use [e-mail] instead)]

sr=sspitzer

I tested it and it works fine.

stephend, I've got this in my local tree.  let me know if you want me to land 
it for you (since your tree has got of blake's changes)

Comment 8

[[e-mail] (gone - use [e-mail] instead)]

Yup, thanks Seth.  That is indeed my patch.  Land it anytime the tree is open.  
Thanks!

Comment 9

[(not reading, please use [e-mail] instead)]

fixed.

thanks for the fix.

Comment 10

[[e-mail] (gone - use [e-mail] instead)]

mass accepting my bugs.

Comment 11

[[e-mail] (gone - use [e-mail] instead)]

I messed up, changing from assigned fixed to resolved fixed..sorry for the spam.

Comment 12

[Sheela Ravindran]

verified using 2001-08-02-08 mac, linux, win98