930086 - [Supersearch] "does not have terms" gives an error that the variable is not a valid choice

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

1. do a super search of : https://crash-stats.mozilla.com/search/?date=%3C%3D2013-10-23+16%3A00%3A00&build_id=%3E20130816074700&product=B2G&version=!has27.0a1&version=!has26.0a2&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform

Expected: 27.0a1 and 26.0a2 are not in the list of results
Actual:

"Oops, an error occured

Please fix the following issues:

    version
        Select a valid choice. !has27.0a1 is not one of the available choices."

Comment 1

[[DEACTIVATED] Adrian Gaudebert]

Already fixed by bug 928098.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Does this have an additional dependency too, Adrian?

https://crash-stats.allizom.org/search/?date=%3C%3D2013-10-23+16%3A00%3A00&build_id=%3E20130816074700&product=B2G&version=!has27.0a1&version=!has26.0a2&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform yields the same as in comment 0.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: staging.png

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Stephend has caught the error still on the staging server; reopening the bug.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

And moving this to milestone 65.

Comment 6

[[DEACTIVATED] Adrian Gaudebert]

Pull request: https://github.com/mozilla/socorro/pull/1630

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/bdc71bd39f33337b9a4afc0e52e99603cdea0fb9
Fixes bug 930086 - Not operator is accepted everywhere. r=peterbe

https://github.com/mozilla/socorro/commit/12729f9e51cdaa9677eca1b31dea8e6f2b8117fc
Merge pull request #1630 from AdrianGaudebert/930086-not-operator

Fixes bug 930086 - Not operator is accepted everywhere.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Matt and I would be happier if :nhirata had a chance to double-check this, but looks good to me using my earlier broken URL from comment 2, which now successfully yields results:

https://crash-stats.allizom.org/search/?date=%3C%3D2013-10-23+16%3A00%3A00&build_id=%3E20130816074700&product=B2G&version=!has27.0a1&version=!has26.0a2&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform