File download on /firefox/new/ stopping animations and content loading on scene 2

VERIFIED FIXED

Status

VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: cmore, Assigned: gauthierm)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [kb=1158414] )

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Created attachment 821158 [details]
IE10 no content loaded

The latest version of /firefox/new/ seems to have regressed with clicking the download button and loading scene 2. Currently, the content does not appear to be pre-loading and thus when the save-as dialog is popped, the animation stops and content is not loaded. I will attach two pictures I took on a IE10 browser.

If you access scene 2 directly, the content loads perfectly.
(Reporter)

Comment 1

5 years ago
Created attachment 821159 [details]
Partial content load on IE10
(Reporter)

Updated

5 years ago
Assignee: nobody → mike
(Reporter)

Updated

5 years ago
Blocks: 868199
(Assignee)

Comment 2

5 years ago
Images are preloading correctly here. What's happening is the animation is partially completing before the browser is unloading the page. We need to add a delay to allow the animation to complete.
(Reporter)

Comment 3

5 years ago
(In reply to Michael Gauthier [:gauthierm] from comment #2)
> Images are preloading correctly here. What's happening is the animation is
> partially completing before the browser is unloading the page. We need to
> add a delay to allow the animation to complete.

A delay is fine because we want users to look at the content before interacting with the save-as dialog box. Should we be consistent with the 2000ms delay in the scene 2 loading directly?
(Assignee)

Comment 5

5 years ago
The PR adds a 500ms delay for the button click case and keeps a 2000ms delay when going to #download-fx.
Whiteboard: [kb=1158414]
The branch from gautherm's PR is on https://www-demo3.allizom.org/en-US/firefox/new/ for testing.
(Reporter)

Comment 7

5 years ago
I cleared the cache on my IE10 box and demo3 is working good. Animation is smooth, everything loads, and the save-as pops up. Going to test other browsers while retornam does his tests too.
(Reporter)

Comment 8

5 years ago
Safari, Chrome, and latest Firefox all appear to be working as expected. We need to test IE 6, 7, 8, 9, and old Firefox.
tested in IE 6,7,8,9, 10 and this works.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 10

5 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/72efabf8532b5b7ce58eb209cadca8e2ef1bc3f2
Add a delay when clicking download button.

[Bug #930131](https://bugzilla.mozilla.org/show_bug.cgi?id=930131)

Delay is needed to allow animation to complete in IE9/10.

https://github.com/mozilla/bedrock/commit/b426868fe8fdb09be830c60373c19e2fa07ee808
Merge pull request #1335 from gauthierm/bug-930131-fix-preloading

Bug 930131: Add a delay when clicking download button.
(Reporter)

Comment 12

5 years ago
Did this never make it to production today?
(Reporter)

Comment 13

5 years ago
I tested it on Chrome on production and it works: https://www.mozilla.org/en-US/firefox/new/
verified fixed on production https://www.mozilla.org/en-US/firefox/new/#download-firefox in IE6, 7, 8 and 9
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.