930131 - File download on /firefox/new/ stopping animations and content loading on scene 2

Status: VERIFIED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Chris More [:cmore]]

Attachment: IE10 no content loaded

The latest version of /firefox/new/ seems to have regressed with clicking the download button and loading scene 2. Currently, the content does not appear to be pre-loading and thus when the save-as dialog is popped, the animation stops and content is not loaded. I will attach two pictures I took on a IE10 browser.

If you access scene 2 directly, the content loads perfectly.

Comment 1

[Chris More [:cmore]]

Attachment: Partial content load on IE10

Comment 2

[Michael Gauthier [:gauthierm]]

Images are preloading correctly here. What's happening is the animation is partially completing before the browser is unloading the page. We need to add a delay to allow the animation to complete.

Comment 3

[Chris More [:cmore]]

(In reply to Michael Gauthier [:gauthierm] from comment #2)
> Images are preloading correctly here. What's happening is the animation is
> partially completing before the browser is unloading the page. We need to
> add a delay to allow the animation to complete.

A delay is fine because we want users to look at the content before interacting with the save-as dialog box. Should we be consistent with the 2000ms delay in the scene 2 loading directly?

Comment 4

[Michael Gauthier [:gauthierm]]

https://github.com/mozilla/bedrock/pull/1335

Comment 5

[Michael Gauthier [:gauthierm]]

The PR adds a 500ms delay for the button click case and keeps a 2000ms delay when going to #download-fx.

Comment 6

[Steven Garrity [:sgarrity]]

The branch from gautherm's PR is on https://www-demo3.allizom.org/en-US/firefox/new/ for testing.

Comment 7

[Chris More [:cmore]]

I cleared the cache on my IE10 box and demo3 is working good. Animation is smooth, everything loads, and the save-as pops up. Going to test other browsers while retornam does his tests too.

Comment 8

[Chris More [:cmore]]

Safari, Chrome, and latest Firefox all appear to be working as expected. We need to test IE 6, 7, 8, 9, and old Firefox.

Comment 9

[raymond [:retornam] (inactive)]

tested in IE 6,7,8,9, 10 and this works.

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/72efabf8532b5b7ce58eb209cadca8e2ef1bc3f2
Add a delay when clicking download button.

[Bug #930131](https://bugzilla.mozilla.org/show_bug.cgi?id=930131)

Delay is needed to allow animation to complete in IE9/10.

https://github.com/mozilla/bedrock/commit/b426868fe8fdb09be830c60373c19e2fa07ee808
Merge pull request #1335 from gauthierm/bug-930131-fix-preloading

Bug 930131: Add a delay when clicking download button.

Comment 11

[raymond [:retornam] (inactive)]

stage tested IE6,7,8,9,10, Chrome https://www.allizom.org/en-US/firefox/new/#download-firefox

Comment 12

[Chris More [:cmore]]

Did this never make it to production today?

Comment 13

[Chris More [:cmore]]

I tested it on Chrome on production and it works: https://www.mozilla.org/en-US/firefox/new/

Comment 14

[raymond [:retornam] (inactive)]

verified fixed on production https://www.mozilla.org/en-US/firefox/new/#download-firefox in IE6, 7, 8 and 9