[B2G][1.2][l10n][Settings]: "Fixed dialing numbers" in Call Settings is not translated across the locales

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: nkhristoforov, Assigned: soumyakanti.chakraborty)

Tracking

({l12y})

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:koi+, b2g-v1.2 fixed)

Details

(Whiteboard: [LocRun1.2],[good first bug])

Attachments

(2 attachments, 1 obsolete attachment)

58.76 KB, image/png
Details
46 bytes, text/x-github-pull-request
kaze
: review+
Details | Review | Splinter Review
(Reporter)

Description

5 years ago
Created attachment 821190 [details]
Screenshot

In Call Settings, the "Fixed dialing numbers" option is not translated across the various languages.

Repro Steps:
1) Updated Buri to BuildID: 20131023004005
2) Choose any non-English language as the language during set-up.
3) Select Settings.
4) Select Call Settings under Wifi.
5) Verify "Fixed dialing numbers" is not translated.

Actual:
"Fixed dialing numbers" is not translated to the selected language.

Expected:
"Fixed dialing numbers" is translated to the selected language.

Environmental Variables:
Device: Buri v 1.2 COM RIL
BuildID: 20131023004005
Gaia: 1ca623e7a79a9653b54a45ef7f8bb03b8d7100fc
Gecko: bb33e2fe109c
Version: 26.0a2
Firmware Version: 20131015

Repro frequency: 100%
See attached: Screenshot
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/elements/call.html#L58 is

<a data-href="#call-fdnSettings" data-l10n-id="fdn">Fixed dialing numbers</a>

data-l10n-id should fdnSettings to use the localized string.
Whiteboard: LocRun1.2 → [LocRun1.2][good first bug]
(Assignee)

Comment 2

5 years ago
The bug is similar to Bug 931640, so I will take it up and please assign it to me.
(Assignee)

Comment 3

5 years ago
Created attachment 824389 [details] [review]
Bug 930165 patch
Attachment #824389 - Flags: review?(archaeopteryx)
(Assignee)

Comment 4

5 years ago
Created attachment 824516 [details] [review]
Bug 930165 patch

Please consider the new pull request
Attachment #824389 - Attachment is obsolete: true
Attachment #824389 - Flags: review?(archaeopteryx)
Attachment #824516 - Flags: review?(archaeopteryx)
Comment on attachment 824516 [details] [review]
Bug 930165 patch

I am not a module peer, so I can't review that. Redirecting to kaze for review.
Attachment #824516 - Flags: review?(archaeopteryx) → review?(kaze)
Assignee: nobody → soumyakanti.chakraborty
Status: NEW → ASSIGNED
Comment on attachment 824516 [details] [review]
Bug 930165 patch

Good catch, thanks!
Attachment #824516 - Flags: review?(kaze) → review+
Merged on master: https://github.com/mozilla-b2g/gaia/commit/aa6565c30133b7e03e1f49161c489918653e2d3e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
blocking-b2g: koi? → koi+
Uplifted aa6565c30133b7e03e1f49161c489918653e2d3e to:
v1.2: c92c6fdb2e8af9d0d2a3f7c0c93877e394fd487a
status-b2g-v1.2: --- → fixed
Still repros on the Croatian, Polish and Serbian (Latin and Cyrillic) languages on Buri 1.2 commercial RIL.  The other languages show the Fixed Dialing Numbers text in their language.

Build ID: 20131108004004
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/a886c641a306
Gaia: 4cf40fb30c7b8380ea83ed0d4efe043b8b81737f
Platform Version: 26.0
RIL Version: 01.02.00.019.102

Updated

5 years ago
No longer blocks: 928174
Whiteboard: [LocRun1.2][good first bug] → [LocRun1.2],[good first bug]
You need to log in before you can comment on or make changes to this bug.