93021 - Tool tip on logo button should conform to change in URL

Status: VERIFIED FIXED

(CCK Graveyard :: CCK-General, defect)

Description

[blee]

Tool tip on throbbing logo button still says "Go to the Netscape home page".
Observed in 7/31 bld.

Comment 1

[tao]

I suspect this is inherited from CCK6.

Comment 2

[blee]

The original description should have been: Tool tip on throbbing logo button 
still says "Go to the Netscape home page" after customizing Logo button URL.

Comment 3

[Barrett Lindstrom]

Updating QA contact to me for half of the CCK bugs while bom-shik is gone.

Comment 4

[Shruti Vasudevan]

After we customize, should the tooltip state something generic like "GO to..."? 
Otherwise we should include a field for the user to enter desirable text to 
appear as tooltip. Another option is to leave the tooltip empty. Suggestions?

Comment 5

[bobj]

The home icon tooltip shows the Home page URL (e.g., 
http://home.netscape.com/bookmark/6_2/homebutton.html), so maybe we should have
the logo toolip show the corresponding logo URL.  It's nice to have some tooltip,
so that it's more discoverable that the icon is actually a link.

In the future, we could have CCK allow the user to customize the tooltip, but not
for the next release.  If we care, we should file a new bug for that.

Comment 6

[tao]

add shannon to CC list.

Comment 7

[Shannon Diener]

Attachment: patch to change tooltip from "Go to the Netscape homepage" to the specified Animated Logo URL

Comment 8

[Shruti Vasudevan]

Shannond,
Attachment (id=51229)
I understand that 5 lines of the patch change the tooltip in IM, mail, composer, 
navigator and address book. What do the other 2 lines change?

If you are working on a bug pls. assign it to yourself.

Comment 9

[bobj]

> In the future, we could have CCK allow the user to customize the tooltip, but
> not for the next release.  If we care, we should file a new bug for that.

Opened bug 102190.  We can decide later if we care...

Comment 10

[Shannon Diener]

+modifyDTD(langenus.xpi,bin/chrome/en-US.jar,locale/en-US/aim/App.dtd,throbber.tooltip,%AnimatedLogoURL%)
 - this should change the url in the Aim/Sidebar window you get when you go to
tasks->Instant Messenger

+modifyDTD(langenus.xpi,bin/chrome/en-US.jar,locale/en-US/aim/chatContent.dtd,throbber.tooltip,%AnimatedLogoURL%)
 - this should change the url in the Aim chat window

+modifyDTD(langenus.xpi,bin/chrome/en-US.jar,locale/en-US/aim/IM.dtd,throbber.tooltip,%AnimatedLogoURL%)
 - this should change the url in the instant message window 

+modifyDTD(langenus.xpi,bin/chrome/en-US.jar,locale/en-US/navigator/navigator.dtd,throbber.tooltip,%AnimatedLogoURL%)
 - navigator windows

+modifyDTD(langenus.xpi,bin/chrome/en-US.jar,locale/en-US/editor/editorOverlay.dtd,throbber.tooltip,%AnimatedLogoURL%)
 - editor window

+modifyDTD(langenus.xpi,bin/chrome/en-US.jar,locale/en-US/messenger/messenger.dtd,throbber.tooltip,%AnimatedLogoURL%)
 - messenger window

+modifyDTD(langenus.xpi,bin/chrome/en-US.jar,locale/en-US/messenger/addressbook/abMainWindow.dtd,throbber.tooltip,%AnimatedLogoURL%)
 - addressbook window

I'm relying on past notes and searches for "Go to the Netscape homepage" and "Go
to the &vendorShortName homepage" for this information.  

However, I've only been working on customizations for a short time so I'm sure
that someone else knows better than I do.

I think Shruti's question concerns AIM in App.dtd, chatContent.dtd, and IM.dtd.
 I relied on past notes for those so I'll double check to be sure that they're
all needed and my information is correct.

Comment 11

[Shannon Diener]

I confirmed that what I said above about App.dtd, IM.dtd, and chatContent.dtd is
correct:
App.dtd is for the window you get when you go to Tasks->Instant Message
IM.dtd is for the IM window 
chatContent.dtd is for the chat window

Comment 12

[Shruti Vasudevan]

r=shrutiv

Comment 13

[bobj]

If no change is made, does the tooltip continue to say "Go to the Netscape home
page"?

Comment 14

[Shannon Diener]

No, if no change is made the tooltip will say http://home.netscape.com which is
the default Animated Logo URL

Comment 15

[Shruti Vasudevan]

Checked in Shannon's patch. Marking fixed.

Comment 16

[bobj]

> No, if no change is made the tooltip will say http://home.netscape.com which
> is the default Animated Logo URL

I think if the logo URL is not changed, then the behavior of the tooltip should
be the same as the standard Netscape release and display "Go to the Netscape
homepage".  The current change is OK for the upcoming release, but I filed
bug 102696 for the next next release.

Comment 17

[Barrett Lindstrom]

verified on build 2001-10-03-09

Comment 18

[Jimmy Uen]

CCK build 2001-10-08-09

Tooltip in Address Book window still display "Go to the Netscape home page"

Comment 19

[Shruti Vasudevan]

Jimmyu,
There was a small glitch...when I cut and pasted Shannon's patch to check in, 
accidentally there was a parentheses missing. I corrected it this morning. It 
should work in the next build.

Marking fixed.

Comment 20

[Jimmy Uen]

Verified with CCK Build 2001-10-15-08 on Win2K.