93024 - Get mPrompter assert for ftp request handling

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Embedding: APIs, defect)

Description

[David Epstein]

1. Launch testembed from /bin folder. If need to compile, go to
/mozilla/embedding/qa/testembed and run nmake -f makefile.win
2. From Interfaces menu, select nsIRequest.
3. Run through ftp request test. (I'll post a patch. You could also make an ftp
entry, like ftp://ftp.netscape.com, in the UriTable[] in Tests.cpp).

Result: Get this assertion: "no prompter!; 'mPrompter' file
/mozilla/netwerk/protocol/ftp/src/nsFtpConnectionThread.cpp line 1848. Press
Ignore allows user to continue. Stack trace is:

nsDebug::Assertion(const char * 0x03654da4, const char * 0x03654d98, const char
* 0x03654d4c, int 1845) line 290 + 13 bytes
nsFtpState::StopProcessing() line 1845 + 47 bytes
nsFtpState::Process() line 624 + 8 bytes
nsFtpState::OnDataAvailable(nsFtpState * const 0x03522270, nsIRequest *
0x03545540, nsISupports * 0x00000000, nsIInputStream * 0x035455f0, unsigned int
53, unsigned int 68) line 455 + 8 bytes
nsFtpControlConnection::OnDataAvailable(nsFtpControlConnection * const
0x03541f20, nsIRequest * 0x03545540, nsISupports * 0x00000000, nsIInputStream *
0x035455f0, unsigned int 53, unsigned int 68) line 315 + 43 bytes
nsOnDataAvailableEvent::HandleEvent() line 178 + 70 bytes
nsARequestObserverEvent::HandlePLEvent(PLEvent * 0x0354f724) line 64
PL_HandleEvent(PLEvent * 0x0354f724) line 590 + 10 bytes
PL_ProcessPendingEvents(PLEventQueue * 0x0118c820) line 520 + 9 bytes
_md_EventReceiverProc(HWND__ * 0x009f01a6, unsigned int 49488, unsigned int 0,
long 18401312) line 1071 + 9 bytes
USER32! 77e71820()
01

Comment 1

[David Epstein]

Attachment: incls ftp request in UriTable[] in Tests.cpp

Comment 2

[Conrad Carlen (not reading bugmail)]

I'll have to look at this but, as I remember, there are situations in which an
ftp connection will not have a prompter. I think it's not harmful - just causes
an assertion from which you can continue. CC'ing dougt because he knows the
story on this.

Comment 3

[Judson Valeski]

-> dougt.

Comment 4

[Doug Turner (:dougt)]

Like with other necko protocols, clients must set notification callbacks on the
channel.  

http://lxr.mozilla.org/seamonkey/source/netwerk/base/public/nsIChannel.idl#81

Not setting nsIPrompt and nsIAuthPrompt on a necko channel prior to opening can
result in problems.  For example, what if the protocol needed to ask for
Username and Password - without an nsIAuthPrompt, the transaction will fail.

This is not a necko problem unless I am missing
something.  Maybe the embedding code need to be setting this on all necko
channels it opens?  ccarlen?

Comment 5

[Conrad Carlen (not reading bugmail)]

-> 0.9.7

Comment 6

[Conrad Carlen (not reading bugmail)]

-> 0.9.9

Comment 7

[Conrad Carlen (not reading bugmail)]

-> mozilla 1.0

Comment 8

[Conrad Carlen (not reading bugmail)]

Mass move to 1.0.1

Comment 9

[David Epstein]

Mozilla 1.0.0 Gecko 20020509 build. Actually now getting 3 separate consecutive
asserts (using ftp://ftp.netscape.com). 
1st: "Server type list format unrecognized: '0', file
/mozilla/netwerk/protocol/ftp/src/nsFtpConnectionThread.cpp line 1215. 
2nd: the mprompter assert. 
3rd: 'ftp read state mixup: '0', ... nsFtpConnectionThread.cpp line 522

Comment 10

[David Epstein]

Attachment: ftp request handling now in nsirequest.cpp in TestEmbed

Comment 11

[Conrad Carlen (not reading bugmail)]

Setting to milestone that's not passed.

Comment 12

[Benjamin Smedberg]

Marking a bunch of bugs in the "Embedding: APIs" component INCOMPLETE in preparation to archive that component. If I have done this incorrectly, please reopen the bugs and move them to a more correct component as we don't have "embedding" APIs any more.