Closed Bug 930242 Opened 6 years ago Closed 6 years ago

Consolidate ogg moz.build files

Categories

(Core :: Audio/Video, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: rillian, Assigned: rillian)

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

Improve readability and parse time by replacing recursive build files with single ones in the top level source directory.
Attached patch Consolidate ogg build files (obsolete) — Splinter Review
Replace recursive build files with a single pair in the top
level source for better readability and parse time.
Attachment #821318 - Flags: review?(ted)
Assignee: nobody → giles
Comment on attachment 821318 [details] [diff] [review]
Consolidate ogg build files

Review of attachment 821318 [details] [diff] [review]:
-----------------------------------------------------------------

Good stuff!
Attachment #821318 - Flags: review?(ted) → review+
Comment on attachment 821318 [details] [diff] [review]
Consolidate ogg build files

Review of attachment 821318 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/libogg/README_MOZILLA
@@ +1,3 @@
>  The source from this directory was copied from the libogg subversion
>  repository using the update.sh script. The only changes made were
> +those applied by update.sh and the addition/upate of moz.build and

update
Rebase on top of changes from bugs 929905 and 930674, and fix the typo Ms2ger noticed. Carrying forward r=ted.
Attachment #821318 - Attachment is obsolete: true
I actually was motivated to write the patch for the latter of those because I noticed that was the only thing left in your Makefile.in. :)
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #5)
> I actually was motivated to write the patch for the latter of those because
> I noticed that was the only thing left in your Makefile.in. :)

Thanks! It was nice to be able to delete the Makefile entirely. A cc would have been nice though.

 -r
https://hg.mozilla.org/mozilla-central/rev/773544d9c681
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.