930242 - Consolidate ogg moz.build files

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Ralph Giles (:rillian)]

Improve readability and parse time by replacing recursive build files with single ones in the top level source directory.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Consolidate ogg build files

Replace recursive build files with a single pair in the top
level source for better readability and parse time.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 821318 [details] [diff] [review]
Consolidate ogg build files

Review of attachment 821318 [details] [diff] [review]:
-----------------------------------------------------------------

Good stuff!

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 821318 [details] [diff] [review]
Consolidate ogg build files

Review of attachment 821318 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/libogg/README_MOZILLA
@@ +1,3 @@
>  The source from this directory was copied from the libogg subversion
>  repository using the update.sh script. The only changes made were
> +those applied by update.sh and the addition/upate of moz.build and

update

Comment 4

[Ralph Giles (:rillian)]

Attachment: Consolidate ogg build files v2

Rebase on top of changes from bugs 929905 and 930674, and fix the typo Ms2ger noticed. Carrying forward r=ted.

Comment 5

[(not currently active) Ted Mielczarek]

I actually was motivated to write the patch for the latter of those because I noticed that was the only thing left in your Makefile.in. :)

Comment 6

[Ralph Giles (:rillian)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/773544d9c681

Comment 7

[Ralph Giles (:rillian)]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #5)
> I actually was motivated to write the patch for the latter of those because
> I noticed that was the only thing left in your Makefile.in. :)

Thanks! It was nice to be able to delete the Makefile entirely. A cc would have been nice though.

 -r

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/773544d9c681