fix infinite recursion in signal handler on non-main-thread in debug builds

RESOLVED FIXED in mozilla27

Status

()

Core
JavaScript Engine
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: luke, Assigned: luke)

Tracking

unspecified
mozilla27
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 821327 [details] [diff] [review]
fix-handler

If you have a real seg-fault on a helper thread, then RuntimeForCurrentThread() will MOZ_ASSERT crash which will recursively call the signal handler and on and on.  This patch adds a PerThreadData::runtimeIfOnOwnerThread() so that RuntimeForCurrentThread() can easily do the right thing.
Attachment #821327 - Flags: review?(bhackett1024)
Attachment #821327 - Flags: review?(bhackett1024) → review+
(Assignee)

Comment 1

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/42f131becd2f
https://hg.mozilla.org/mozilla-central/rev/42f131becd2f
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.