Closed Bug 930260 Opened 6 years ago Closed 6 years ago

fix infinite recursion in signal handler on non-main-thread in debug builds

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: luke, Assigned: luke)

Details

Attachments

(1 file)

Attached patch fix-handlerSplinter Review
If you have a real seg-fault on a helper thread, then RuntimeForCurrentThread() will MOZ_ASSERT crash which will recursively call the signal handler and on and on.  This patch adds a PerThreadData::runtimeIfOnOwnerThread() so that RuntimeForCurrentThread() can easily do the right thing.
Attachment #821327 - Flags: review?(bhackett1024)
Attachment #821327 - Flags: review?(bhackett1024) → review+
https://hg.mozilla.org/mozilla-central/rev/42f131becd2f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.