930362 - [LockScreen] The icons' background would light up when touch on them

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Greg Weng [:snowmantw][:gweng][:λ]]

I've kept some legacy code and styles, which may cause this problem.
I'll seek for simple fixes only affect CSS as soon as possible.

Bad news is that this only happens on devices. On FirefoxNightly it would not happen.

Comment 1

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Camera area light up

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Unlock area light up

Add screenshots show that the areas got light up.

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

I've confirmed that this can be fixed by set these two elements' CSS attributes 'pointer-event' to 'none'.
The current setting was added in the Bug 916282, which wanted to improve the LockScreen in screen reader.
Therefore I will needinfo Eitan to see how to handle this and avoid to make the screen reader broken.

Comment 4

[Eitan Isaacson [:eeejay]]

Making pointer events none, will not allow blind users to discover these icons by touch. Is there another solution?

Comment 5

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

Fixed it with CSS style adjustments, without touch the pointer-event attribute.

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/8f01f87a1e74475ba681a37d74450d2b6361c627

later would merge to v1.2

Comment 7

[Greg Weng [:snowmantw][:gweng][:λ]]

v1.2: https://github.com/mozilla-b2g/gaia/commit/37c050b5bb5e88d365253b411a701d0da007f74b