930369 - Large favicons are not scaled in the history subview

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Matthew N. [:MattN]]

Attachment: Screenshot of the history subview with a large favicon

See the screenshot. I don't know if this affects all subsections of the subview or not. We should be using -moz-resolution (like we do on the tab favicons) along with setting a height and width.

Marking as P2 since it's our own start page that causes the issue and it's likely to be in that history menu for many users.

Comment 1

[Marco Bonardo [:mak]]

where do we get that icon from? all stored favicons are 16x16 in the backend, so must come from somewhere else

Comment 2

[:Gijs (he/him)]

(In reply to Marco Bonardo [:mak] from comment #1)
> where do we get that icon from? all stored favicons are 16x16 in the
> backend, so must come from somewhere else

It's not stored, it's the 'recently closed tabs/windows' menus.

Comment 3

[:Gijs (he/him)]

Attachment: fix recently closed favicons,

This should do the trick.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 823271 [details] [diff] [review]
fix recently closed favicons,

Review of attachment 823271 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good - thanks Gijs.

Comment 5

[:Gijs (he/him)]

https://hg.mozilla.org/projects/ux/rev/75fb5d8c7087

Comment 7

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/75fb5d8c7087