Closed
Bug 930369
Opened 10 years ago
Closed 10 years ago
Large favicons are not scaled in the history subview
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: MattN, Assigned: Gijs)
References
(Blocks 1 open bug, )
Details
(Whiteboard: [Australis:P2][Australis:M9])
Attachments
(2 files)
9.25 KB,
image/png
|
Details | |
1.26 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
See the screenshot. I don't know if this affects all subsections of the subview or not. We should be using -moz-resolution (like we do on the tab favicons) along with setting a height and width. Marking as P2 since it's our own start page that causes the issue and it's likely to be in that history menu for many users.
Comment 1•10 years ago
|
||
where do we get that icon from? all stored favicons are 16x16 in the backend, so must come from somewhere else
Assignee | ||
Comment 2•10 years ago
|
||
(In reply to Marco Bonardo [:mak] from comment #1) > where do we get that icon from? all stored favicons are 16x16 in the > backend, so must come from somewhere else It's not stored, it's the 'recently closed tabs/windows' menus.
Assignee | ||
Comment 3•10 years ago
|
||
This should do the trick.
Attachment #823271 -
Flags: review?(mconley)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment 4•10 years ago
|
||
Comment on attachment 823271 [details] [diff] [review] fix recently closed favicons, Review of attachment 823271 [details] [diff] [review]: ----------------------------------------------------------------- Looks good - thanks Gijs.
Attachment #823271 -
Flags: review?(mconley) → review+
Assignee | ||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/projects/ux/rev/75fb5d8c7087
Whiteboard: [Australis:P2] → [Australis:P2][Australis:M9][fixed-in-ux]
Reporter | ||
Updated•10 years ago
|
Assignee | ||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/75fb5d8c7087
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P2][Australis:M9][fixed-in-ux] → [Australis:P2][Australis:M9]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•