Closed
Bug 930398
Opened 11 years ago
Closed 11 years ago
[Wifi][WPA-EAP] keystore doesn't free memory after getting cert.
Categories
(Firefox OS Graveyard :: Wifi, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: chucklee, Assigned: chucklee)
Details
Attachments
(1 file, 2 obsolete files)
|
1.46 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•11 years ago
|
Summary: [Wifi][WPA-EAP] keystore doesn't memory after getting cert. → [Wifi][WPA-EAP] keystore doesn't free memory after getting cert.
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #826659 -
Flags: review?(khuey)
Attachment #826659 -
Flags: review?(brian)
Comment on attachment 826659 [details] [diff] [review] Release cert after use. Review of attachment 826659 [details] [diff] [review]: ----------------------------------------------------------------- I think bsmith is more qualified to review this than I am.
Attachment #826659 -
Flags: review?(khuey)
Comment on attachment 826659 [details] [diff] [review] Release cert after use. Review of attachment 826659 [details] [diff] [review]: ----------------------------------------------------------------- This should be fine. You can also just use a ScopedCERTCertificate (see https://mxr.mozilla.org/mozilla-central/source/security/manager/ssl/src/ScopedNSSTypes.h#81 ).
Attachment #826659 -
Flags: review?(brian) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Address comment 3
Attachment #826659 -
Attachment is obsolete: true
Attachment #829083 -
Flags: review?(dkeeler)
|
|
Assignee | |
Comment 5•11 years ago
|
||
Try : https://tbpl.mozilla.org/?tree=Try&rev=ea0c8f93fae9
Comment on attachment 829083 [details] [diff] [review] Use ScopedCERTCertificate instead. Review of attachment 829083 [details] [diff] [review]: ----------------------------------------------------------------- Looks good.
Attachment #829083 -
Flags: review?(dkeeler) → review+
|
|
Assignee | |
Comment 7•11 years ago
|
||
Run try again for there are some failures seems not caused by this patch but I can't rerun : https://tbpl.mozilla.org/?tree=Try&rev=60cd9fd2f899
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 8•11 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/cc565d1677da
Keywords: checkin-needed
|
|
||
Comment 9•11 years ago
|
||
Backed out for bustage. https://hg.mozilla.org/integration/b2g-inbound/rev/6408a90c2ded https://tbpl.mozilla.org/php/getParsedLog.php?id=30419336&tree=B2g-Inbound
Looks like the patch that ran on try is different from the one checked in. In particular, that patch is missing '#include "ScopedNSSTypes.h"'.
|
|
Assignee | |
Comment 11•11 years ago
|
||
Sorry I forgot to update the patch.
Attachment #829083 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
|
||
Comment 12•11 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/36e5d34076e5
Keywords: checkin-needed
|
|
||
Comment 13•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/36e5d34076e5
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•