930422 - explicit initialization for AudioDestinationNode

Status: NEW

(Core :: Web Audio, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/28.0.1500.95 Safari/537.36

Steps to reproduce:

Follow-up bug for https://bugzilla.mozilla.org/show_bug.cgi?id=927322#c19.

It's usually unsafe to pass the object pointer to generic XPCOM code before it's fully constructed and a first strong reference to it has been created. We might want to use 2-stage-initialization to enforce safe use of the object.

Comment 1

[(no longer active)]

Oh, sorry, I meant that we should do this for AudioDestinationNode.

Comment 2

[Karl Tomlinson (:karlt)]

Or add a factory method and make the constructor private.

Comment 3

[(no longer active)]

(In reply to comment #2)
> Or add a factory method and make the constructor private.

If the factory method returns an already_AddRefed, that's fine.  In fact, that may be a better option!  :-)

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

(In reply to :Ehsan Akhgari (needinfo? me!) [Away 10/29-11/6] from comment #1)
> Oh, sorry, I meant that we should do this for AudioDestinationNode.

It's a relief we just need to modify one class in this bug.

Comment 5

[Bulk Bug Changes for mreavy's org]

Mass change P2->P3 to align with new Mozilla triage process.