93049 - Sorting by "Site" or "Cookie Name" selects another cookie

Status: VERIFIED FIXED

(Core :: Networking: Cookies, defect, P3)

Description

[Henrik Gemal]

If you go into your Cookie Manager and select the Stored Cookies.
Now select the first cookie. Now click the "Cookie Name" column to get the 
cookies sorted by cookie name. Now the selected cookie if still the first one 
but the Data in "Information about the selected cookie" doesn't change which is 
wrong.

When you sort using the columns the original selected cookie should be selected 
againg and the display should be scrolled to the position. I know this is a bit 
hard. Perhaps I could live with the "Information about..." just being updated so 
it reflects the actual selected cookie.

Build 20010731

Comment 1

[Stephen P. Morse]

Attachment: retain selected cookie after sort

Comment 2

[Stephen P. Morse]

Attachment: same as above but with garbage removed from file

Comment 3

[Stephen P. Morse]

vishy, blake, please review

Comment 4

[Blake Ross]

I filed a bug on retaining selection during column sort awhile ago.  I believe
the correct way to fix this is to fix it on the toolkit end: the currently
selected item should continue to be selected after a sort, and then a select
event should probably fire so, for example, the cookie description information
would get updated. 

Comment 5

[Stephen P. Morse]

But in the iterim we are not doing the sort in the toolkit but rather the cookie 
manager is doing its own sort.  So this patch is necessary as long as we are 
doing it that way.

Probably a similar patch should be made for image manager and password manager, 
since they also do their own sorts (using the same sort routine that cookie 
manager used).  However there its not terrible -- the only problem is that you 
have the wrong item selected after the sort is done.  In this case you have 
something worse -- you are displaying the details of one cookie but showing 
another as the selected cookie.

So the image manager and password manager problem can wait for the toolkit sort 
to be implemented.  This one cannot.

Comment 6

[Viswanath Ramachandran]

Adding paul to Cc to do the review instead of vishy. 

Comment 7

[Stephen P. Morse]

cc'ing matt for review

Comment 8

[Paul Chen]

looks ok, r=pchen

Comment 9

[Brendan Eich [:brendan]]

FYI, those id.substring calls can omit the second id.length args, as the default
fencepost is the string length.  The JS will be ever so slightly faster.
sr=[e-mail] either way.

/be

Comment 10

[Stephen P. Morse]

Fix checked in.

Comment 11

[Tom Everingham]

verified:  Information about original selected cookie retained after sorting.

Win2000 2001-09-24-05-0.9.4
Mac os9 2001-09-24-03-0.9.4
Linux rh6 2001-09-24-04-0.9.4