Closed
Bug 930538
Opened 11 years ago
Closed 11 years ago
[e.me][feature] Add Collections - l10n follow-ups
Categories
(Firefox OS Graveyard :: Gaia::Everything.me, defect)
Tracking
(blocking-b2g:1.3+)
RESOLVED
FIXED
blocking-b2g | 1.3+ |
People
(Reporter: Pike, Assigned: amirn)
References
Details
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #910354 +++ A few of the changed strings in bug 910354 got changed without their IDs: evme-alert-offline-shortcuts-more evme-alert-shortcuts-suggest-empty evme-alert-no-more-shortcuts
Reporter | ||
Comment 1•11 years ago
|
||
Can I get some traction on this bug, please?
blocking-b2g: --- → koi?
Comment 2•11 years ago
|
||
(In reply to Axel Hecht [:Pike] from comment #0) > +++ This bug was initially created as a clone of Bug #910354 +++ > > A few of the changed strings in bug 910354 got changed without their IDs: > > evme-alert-offline-shortcuts-more > evme-alert-shortcuts-suggest-empty > evme-alert-no-more-shortcuts :pike can you please help understand whats the end user impact without having these IDS unchanged and how it impacts l10n. I am NI'ing Amir from e.me to already help here as this is a fallout from 910354.
Flags: needinfo?(amirn)
Comment 3•11 years ago
|
||
(In reply to bhavana bajaj [:bajaj] from comment #2) > > A few of the changed strings in bug 910354 got changed without their IDs: > > > > evme-alert-offline-shortcuts-more > > evme-alert-shortcuts-suggest-empty > > evme-alert-no-more-shortcuts > > :pike can you please help understand whats the end user impact without > having these IDS unchanged and how it impacts l10n. When a string changes without a new ID, localizers won't notice the new content and consider the old string still good. If the ID changes, the string will be marked as missing from the localization, localizers will be aware of the change and take action. That's the way it works across all Mozilla projects https://developer.mozilla.org/en-US/docs/Making_String_Changes
Comment 4•11 years ago
|
||
triage: since e.me is a core experience, blocking+ to have missing strings translated
blocking-b2g: koi? → koi+
Assignee | ||
Comment 5•11 years ago
|
||
Thanks Axel. I'll rename the keys.
Assignee: nobody → amirn
Flags: needinfo?(amirn)
Assignee | ||
Comment 6•11 years ago
|
||
Attachment #829457 -
Flags: review?(ran)
Reporter | ||
Comment 7•11 years ago
|
||
Comment on attachment 829457 [details]
redirect to PR 13528.html
I don't see the code change for evme-alert-collections-suggest-empty ?
(PS: You can just copy the PR url into the attachment window now, and bugzilla will do the redirect magic for you)
Assignee | ||
Comment 8•11 years ago
|
||
(In reply to Axel Hecht [:Pike] from comment #7)> > I don't see the code change for evme-alert-collections-suggest-empty ? The original key 'evme-alert-shortcuts-suggest-empty' was actually not used anywhere, which is probably a mistake.
Reporter | ||
Comment 9•11 years ago
|
||
should that string be removed then? I'm not confident that I can actually reproduce how the string IDs are generated.
Assignee | ||
Comment 10•11 years ago
|
||
(In reply to Axel Hecht [:Pike] from comment #9) > should that string be removed then? I'm not confident that I can actually > reproduce how the string IDs are generated. ok. removed the string and updated PR > (PS: You can just copy the PR url into the attachment window now, and > bugzilla will do the redirect magic for you) thanks for the tip :)
Updated•11 years ago
|
Attachment #829457 -
Flags: review?(ran) → review+
Assignee | ||
Comment 11•11 years ago
|
||
landed https://github.com/mozilla-b2g/gaia/commit/01e75ce112c15d5620f395780858de2ae0ac4dd9
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 12•11 years ago
|
||
I was not able to uplift this bug to v1.2. If this bug has dependencies which are not marked in this bug, please comment on this bug. If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval. Otherwise, if this is just a merge conflict, you might be able to resolve it with: git checkout v1.2 git cherry-pick -x -m1 01e75ce112c15d5620f395780858de2ae0ac4dd9 <RESOLVE MERGE CONFLICTS> git commit
Flags: needinfo?(amirn)
Assignee | ||
Comment 13•11 years ago
|
||
This bug depends on bug 910354 which will only land in 1.3. clearing koi? and setting 1.3?
blocking-b2g: koi+ → 1.3?
Flags: needinfo?(amirn)
Comment 14•11 years ago
|
||
Blocking+ for 1.3 e.me feature set - needed for l10n
blocking-b2g: 1.3? → 1.3+
Reporter | ||
Comment 15•10 years ago
|
||
Removing late-l10n keyword as this only landed on master.
Keywords: late-l10n
You need to log in
before you can comment on or make changes to this bug.
Description
•