930545 - [Browser] Adding a bookmark to home screen test fails

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[[:AndreiH]]

Our automated tests picked up that adding a bookmark to Home screen fails, because bookmark is not added to home screen

Steps to reproduce:

1. Open the Browser
2. Go to a random url
3. Tap on bookmark button and add it to the home screen
4. Verify the home screen

Expected results:
Bookmark should be present on home screen

Actual results:
Bookmark is not posted on home screen

NOTE: this can be replicated on both hamachi and desktob2g nightlies

Comment 1

[Zac C (:zac)]

Hamachi nightly build:
Gecko  http://hg.mozilla.org/mozilla-central/rev/19fd3388c372
Gaia  62a84888f1c10556af8fbbd50e126bb1afe96276
BuildID 20131024040207
Version 27.0a1

Comment 2

[Anthony Ricaud (:rik)]

Looking on Travis, this looks like a Gecko issue.

Comment 3

[Anthony Ricaud (:rik)]

Ben: Could you find an owner for this? This looks like a bad regression.

Comment 4

[Jason Smith [:jsmith]]

Can someone get a logcat with this? It will help in diagnosing this bug.

Comment 5

[Marcia Knous [:marcia]]

Attachment: Logcat while trying to add bookmark to the homescreen

Buri device, using:

Gaia   2feebdb1a2583928f32407d76d798f8654621e2b
SourceStamp 19fd3388c372
BuildID 20131024154023
Version 27.0a1

Same thing happens with e.me as well.

Comment 6

[Anthony Ricaud (:rik)]

I believe this is similar to bug 930810 and it's a postMessage issue. bookmark_editor.js uses postMessage to talk to the homescreen window.

Comment 7

[:gerard-majax]

I'm having a look.

Comment 8

[:gerard-majax]

My gecko at 7f0f9ca7faffa7b48f762512b92043f55d550bdf does not exposes the issue on Inari

Comment 9

[Ben Francis [:benfrancis]]

Are you happy to look into this further if we can get a regression window gerard-majax?

Comment 10

[:gerard-majax]

(In reply to Ben Francis [:benfrancis] from comment #9)
> Are you happy to look into this further if we can get a regression window
> gerard-majax?

As Anthony made me notice, there's one proposed in bug 930810#c3

Comment 11

[:gerard-majax]

I'm gonna bisect between git commits f5bae2e96f6007a375a61c46c8c4db8d628184a6 and 0e4e01758ccdd6a76e24c7fb6324d38f7060b8ee, according to sources.xml of pvtbuilds matching the buildid that are referred to in bug 930810 comment 3

Comment 12

[Jason Smith [:jsmith]]

The regression window by daily testing is already known - this was working yesterday on the 10/23 build, broken on today's 10/24 build. We do not have builds to deeper bisect this on the QA side.

10/23 - Last Working

https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2gotoro/nightly/mozilla-central-hamachi-eng/2013/10/2013-10-23-04-02-03/sources.xml

10/24 - First Failed

https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2gotoro/nightly/mozilla-central-hamachi-eng/2013/10/2013-10-24-04-02-07/sources.xml

Comment 13

[:gerard-majax]

We bisected it to 9ec3e78b2350b1990f1140ca3d3f0890a1c31d42. It's from bug 924702, and the missing follow up bug 930836 does not help.

Comment 14

[Jason Smith [:jsmith]]

Fixed by backout in bug 924702.

Comment 15

[Anthony Ricaud (:rik)]

I've re-enabled the test in https://github.com/mozilla-b2g/gaia/commit/3d60c6a5322f077489ece2d9bcbfcd453e1ab63b.

Comment 16

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified; this test has been fine for a while.