930696 - Upgrade internal bootstrap for dash to 3.0 and store in src/bootstrap

Status: RESOLVED FIXED

(Testing Graveyard :: Eideticker, defect)

Description

[William Lachance (:wlach)]

Before I do bug 930143 (as well as the as-yet unfiled bug to make the dashboard work with the more granular set of data we'll be using for b2g), it would be nice to use a more modern bootstrap, as well as externalize the dependency for clarity.

Comment 1

[William Lachance (:wlach)]

Attachment: Upgrade to bootstrap 3.0, modernize look

Comment 2

[William Lachance (:wlach)]

New dashboard in action here: http://people.mozilla.org/~wlachance/new_dash/

Comment 3

[William Lachance (:wlach)]

Ran new dashboard by jeads and he had some suggestions which I will implement soon. However, he pointed out a rather major problem in that the graph data window could be positioned underneath the graph if the width was too small. I came up with a patch to fix this issue.

Comment 4

[William Lachance (:wlach)]

Attachment: 0001-Bug-930696-Fix-layout-so-data-panel-never-below-grap.patch

This builds on the previous patch. On the downside it fixes the layout which is kind of icky, but I think this was the right thing to do here since I think we need the maximal degree of control over content layout to get the maximum out of data displayed. It should pave the way to let us do all sorts of neat stuff in the future.

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Screenshot from 2013-10-30 11:10:45.png

Screenshot of footer through the center of the page.

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 824248 [details] [diff] [review]
0001-Bug-930696-Fix-layout-so-data-panel-never-below-grap.patch

Review of attachment 824248 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, except for the footer appearing in the middle of the page. I've attached a screenshot as I suspect with more tests in the list this wouldn't be an issue.

Comment 7

[William Lachance (:wlach)]

Attachment: 0001-Bug-930696-Upgrade-to-bootstrap-3.0-modernize-look-o.patch

This should fix the issues with the positioning of the footer and some problems with the data panel not moving as required when the window is resized.

Comment 8

[William Lachance (:wlach)]

Attachment: 0001-Bug-930696-Upgrade-to-bootstrap-3.0-modernize-look-o.patch

Fixes/improves a few things from the previous patch: the width was incorrect, better bootstrap including.

Comment 9

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 828165 [details] [diff] [review]
0001-Bug-930696-Upgrade-to-bootstrap-3.0-modernize-look-o.patch

Review of attachment 828165 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, this does look better. Thanks!

Comment 10

[William Lachance (:wlach)]

Pushed: https://github.com/mozilla/eideticker/commit/f7eeb32a0075d59a5fef7ba3b9486b5eab353739