930718 - Move Solaris define to moz.build

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Ralph Giles (:rillian)]

We've been carrying at patch against vorbis to define HAVE_ALLOCA_H on Solaris. (Bug  469639.) Upstream doesn't want to take the patch because the autoconf build system there sets this based on a test.

As such it's better for us to handle this as a conditional in our build scripts rather than patching a header.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Move solaris define to moz.build

Boying, I'd appreciate it if you could test this patch on Solaris. I think the 'SunOS' test is equivalent, but I can't verify in a build myself.

Comment 2

[Ralph Giles (:rillian)]

Attachment: Move solaris define to moz.build

Rebased on top of bugs 930228, 930228, 930674, 929905 and 914270. Carrying forward r=ted

Comment 3

[Ralph Giles (:rillian)]

Attachment: Move solaris define to moz.build v3

Fix indent.

Comment 4

[Ralph Giles (:rillian)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cdd6ecfa8487

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cdd6ecfa8487

Comment 6

[Ralph Giles (:rillian)]

Attachment: fix readme

Missed a reference to the removed patch in the readme.

Comment 7

[Ralph Giles (:rillian)]

Attachment: 0002-Bug-930718-Revert-os.h-to-upstream-version.-r-cpearc.patch

Thanks. One more piece.

Comment 8

[Ralph Giles (:rillian)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/07cf3ae8e881
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e4102c7f90e

Comment 9

[Ralph Giles (:rillian)]

Comment on attachment 823897 [details] [diff] [review]
Move solaris define to moz.build v3

Nevermind.