Closed Bug 930718 Opened 8 years ago Closed 8 years ago

Move Solaris define to moz.build

Categories

(Core :: Audio/Video, defect)

All
OpenSolaris
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(3 files, 2 obsolete files)

We've been carrying at patch against vorbis to define HAVE_ALLOCA_H on Solaris. (Bug  469639.) Upstream doesn't want to take the patch because the autoconf build system there sets this based on a test.

As such it's better for us to handle this as a conditional in our build scripts rather than patching a header.
Attached patch Move solaris define to moz.build (obsolete) — Splinter Review
Boying, I'd appreciate it if you could test this patch on Solaris. I think the 'SunOS' test is equivalent, but I can't verify in a build myself.
Attachment #821932 - Flags: review?(ted)
Attachment #821932 - Flags: feedback?(eagle.lu)
Attachment #821932 - Flags: review?(ted) → review+
Attached patch Move solaris define to moz.build (obsolete) — Splinter Review
Rebased on top of bugs 930228, 930228, 930674, 929905 and 914270. Carrying forward r=ted
Attachment #821932 - Attachment is obsolete: true
Attachment #821932 - Flags: feedback?(eagle.lu)
Attachment #823890 - Flags: feedback?(eagle.lu)
Fix indent.
Attachment #823890 - Attachment is obsolete: true
Attachment #823890 - Flags: feedback?(eagle.lu)
Attachment #823897 - Flags: feedback?(eagle.lu)
https://hg.mozilla.org/mozilla-central/rev/cdd6ecfa8487
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Attached patch fix readmeSplinter Review
Missed a reference to the removed patch in the readme.
Attachment #829978 - Flags: review?(cpearce)
Attachment #829978 - Flags: review?(cpearce) → review+
Thanks. One more piece.
Attachment #830544 - Flags: review?(cpearce)
Attachment #830544 - Flags: review?(cpearce) → review+
Comment on attachment 823897 [details] [diff] [review]
Move solaris define to moz.build v3

Nevermind.
Attachment #823897 - Flags: feedback?(eagle.lu)
You need to log in before you can comment on or make changes to this bug.