930731 - Make Ubuntu able to run toplevel::server

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: Puppet, task)

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug930731.patch

since you spoke up

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 821949 [details] [diff] [review]
bug930731.patch

Review of attachment 821949 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/nrpe/manifests/service.pp
@@ +13,5 @@
> +                    ensure => "running",
> +                    require => Class['packages::nrpe'];
> +            }
> +        }
> +        Ubuntu: {

huh, two Ubuntu cases are almost certainly wrong. And isn't |service{ nrpe}| already being used for ubuntu? whats the difference

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 821949 [details] [diff] [review]
bug930731.patch

Review of attachment 821949 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/nrpe/manifests/service.pp
@@ +13,5 @@
> +                    ensure => "running",
> +                    require => Class['packages::nrpe'];
> +            }
> +        }
> +        Ubuntu: {

The service is named "nagios-nrpe-server" on Ubuntu.  Until now we haven't been running nrpe on Ubuntu (it's testers only).  I should have changed the second occurrence of "Ubuntu" to "CentOS", so good catch.

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug930731-p1.patch

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 822372 [details] [diff] [review]
bug930731-p1.patch

https://hg.mozilla.org/build/puppet/rev/73366bc7942f

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

One more bit here, that wasn't present on relabs where I tested this:

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: cannot install on Ubuntu at /etc/puppet/production/modules/packages/manifests/ganglia.pp:14 on node ubuntu64packager1.srv.releng.use1.mozilla.com

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

Also, the nrpe plugin path is wrong, and the stupid thing has decided to fire up a nagios server:

DISK CRITICAL - /home/cltbld/.gvfs is not accessible: Permission denied

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug930731-p2.patch

Comment 9

[Jake Watkins [:dividehex]]

Comment on attachment 825357 [details] [diff] [review]
bug930731-p2.patch

Review of attachment 825357 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 10

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 825357 [details] [diff] [review]
bug930731-p2.patch

https://hg.mozilla.org/build/puppet/rev/2ec798488834