If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Assert in gfxPlatform::ScreenReferenceDrawTarget that there is no clipping or transform

NEW
Assigned to

Status

()

Core
Graphics
4 years ago
4 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Matt points out that the DrawTarget returned by gfxPlatform::ScreenReferenceDrawTarget may have overlapping consumers. In general consumers probably only want to get the DrawTarget's PathBuilder, in which case there is no problem, but if consumers start setting clip paths or transforms on the DrawTarget then there is the potential that they could interfere with each other.

Perhaps we should assert in ScreenReferenceDrawTarget() that there is no clipping or transform applied to the DrawTarget before we return it? This doesn't guarantee that we'll catch consumers that might interfere with each other, but it substantially increases the chance that we will.
You need to log in before you can comment on or make changes to this bug.