93082 - FIX xpccomponets.cpp use of scriptable to deal better with prototype use

Status: VERIFIED WORKSFORME

(Core :: XPConnect, defect, P3)

Description

[David Bradley]

The issue here is that the scriptable handlers in the classes in
xpccomponents.cpp may not really do the right thing when the JSObjects are used
as protos of other JSObjects. I *think* these methods assume that the target
object of a call is the same object that is the JSObject of the wrapper rather
than checking the object that was passed in.

Comment 1

[David Bradley]

Attachment: Attempt to create JS code that demonstrates the problem

I created the attached JS code to try and demonstrate the problem. My
assumption is that if it had the wrong object the property would get defined on
the object instead of the prototype and thus stick around after the prototype
was reset. I've learned not to trust my assumptions, though ;-) The test
doesn't show any problems.

Comment 2

[David Bradley]

Marking this WORKSFORME for previos comments reasons.

Comment 3

[John Bandhauer]

Yeah, I'm not seeing any places in the code that look wrong either.