Closed Bug 930876 Opened 7 years ago Closed 7 years ago

Speed up per-tab profiling of JS by skipping the expensive string hashing.

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: njn, Assigned: njn)

Details

Attachments

(1 file)

The string hashing done in JS memory profiling is expensive and not used by the
per-tab measurements.
Time taken to profile JS memory:

                before  after
gmail.com       21ms    7ms
techcrunch.com  19ms    9ms

With the patch applied, |perf| tells me that there is nothing beyond that worth
optimizing -- most of the time is spent in malloc_usable_size().
Attachment #822151 - Flags: review?(till)
Comment on attachment 822151 [details] [diff] [review]
Speed up per-tab profiling of JS by skipping the expensive string hashing.

Review of attachment 822151 [details] [diff] [review]:
-----------------------------------------------------------------

nice!
Attachment #822151 - Flags: review?(till) → review+
https://hg.mozilla.org/mozilla-central/rev/2d537818dfb9
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.