930896 - Properly keep track of files generated by a backend

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Currently, when the backend creates the files it creates, it doesn't track what it created. If for some reason (configuration switch, moz.build change, etc.) some of those files are not created anymore, they are left in the objdir.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Keep track of files generated by a build backend

The backend.RecursiveMakefile filename change is because as no moz.build is changed here, without a file name change, the list would not be filled until there is a moz.build change. (or a configuration change, or anything else touching backend files)
(And the .built filename doesn't really match the new purpose)

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 822368 [details] [diff] [review]
Keep track of files generated by a build backend

Review of attachment 822368 [details] [diff] [review]:
-----------------------------------------------------------------

W00t.

::: python/mozbuild/mozbuild/backend/base.py
@@ +46,5 @@
>  
>          # The number of unchanged backend files.
>          self.unchanged_count = 0
>  
> +        # The number of delete backend files.

deleted

Comment 3

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/36981d3a0d3b

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/36981d3a0d3b