Properly keep track of files generated by a backend

RESOLVED FIXED in mozilla28

Status

()

Core
Build Config
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla28
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Currently, when the backend creates the files it creates, it doesn't track what it created. If for some reason (configuration switch, moz.build change, etc.) some of those files are not created anymore, they are left in the objdir.
(Assignee)

Updated

4 years ago
Depends on: 930899
(Assignee)

Updated

4 years ago
OS: Linux → All
Hardware: x86_64 → All
(Assignee)

Comment 1

4 years ago
Created attachment 822368 [details] [diff] [review]
Keep track of files generated by a build backend

The backend.RecursiveMakefile filename change is because as no moz.build is changed here, without a file name change, the list would not be filled until there is a moz.build change. (or a configuration change, or anything else touching backend files)
(And the .built filename doesn't really match the new purpose)
Attachment #822368 - Flags: review?(gps)

Comment 2

4 years ago
Comment on attachment 822368 [details] [diff] [review]
Keep track of files generated by a build backend

Review of attachment 822368 [details] [diff] [review]:
-----------------------------------------------------------------

W00t.

::: python/mozbuild/mozbuild/backend/base.py
@@ +46,5 @@
>  
>          # The number of unchanged backend files.
>          self.unchanged_count = 0
>  
> +        # The number of delete backend files.

deleted
Attachment #822368 - Flags: review?(gps) → review+
(Assignee)

Comment 3

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/36981d3a0d3b
https://hg.mozilla.org/mozilla-central/rev/36981d3a0d3b
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.