Closed Bug 930896 Opened 7 years ago Closed 7 years ago

Properly keep track of files generated by a backend

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla28

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

Currently, when the backend creates the files it creates, it doesn't track what it created. If for some reason (configuration switch, moz.build change, etc.) some of those files are not created anymore, they are left in the objdir.
Depends on: 930899
OS: Linux → All
Hardware: x86_64 → All
The backend.RecursiveMakefile filename change is because as no moz.build is changed here, without a file name change, the list would not be filled until there is a moz.build change. (or a configuration change, or anything else touching backend files)
(And the .built filename doesn't really match the new purpose)
Attachment #822368 - Flags: review?(gps)
Comment on attachment 822368 [details] [diff] [review]
Keep track of files generated by a build backend

Review of attachment 822368 [details] [diff] [review]:
-----------------------------------------------------------------

W00t.

::: python/mozbuild/mozbuild/backend/base.py
@@ +46,5 @@
>  
>          # The number of unchanged backend files.
>          self.unchanged_count = 0
>  
> +        # The number of delete backend files.

deleted
Attachment #822368 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/36981d3a0d3b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.