930929 - [Contacts] Contact's address information is not shown in the contact details view

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[isabelrios]

10/25 master build:
Gecko-0e4e017
Gaia-ed6b6eb

STR
1. Create a new contact
2. Add name, phone number and address information (street, zip code, city, country)
3. Tap on Done
4. Check the contact's details view

EXPECTED
All the information added to a contact should be shown fine

ACTUAL
The information about the address(street, zip code, city, country) is not shown in the contact's details view

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

It looks like this was found on 1.3.  Are we sure this happens on 1.2?  It could be related to the webidl issues we've been having.  Just asking for the koi? nom.

Comment 2

[Jose Manuel Cantera]

Isabel, Please could you check whether this reproduces on v1.2?

Comment 3

[isabelrios]

Hi,

Cannot reproduce this on v1.2 (10/28 build):

Gecko-e8d81ae
Gaia-2ef9bc3

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Removing koi? nom based on comment 3.  Thanks!

Comment 5

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: 13257.html

contact.hasOwnProperty(attr) is returning false even in the case when contact is a valid mozContact instance and attr is a contact property.

Comment 6

[Jose Manuel Cantera]

Comment on attachment 825247 [details]
13257.html

thanks Germán

Comment 7

[Germán Toro del Valle (:gtorodelvalle)]

I created bug 933200 to track the hasOwnProperty() function issue on mozContact instances.

Comment 8

[Germán Toro del Valle (:gtorodelvalle)]

Merged in master: https://github.com/mozilla-b2g/gaia/commit/7b11666842e7c79d87547c821c084d4c6fa70447

Comment 9

[Germán Toro del Valle (:gtorodelvalle)]

Comment on attachment 825247 [details]
13257.html

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): New mozContact WebIDL
[User impact] if declined: The postal address is not shown in the contact details
[Testing completed]: Tested in the device.
[Risk to taking this patch] (and alternatives if risky): Very low.
[String changes made]: None.

Comment 10

[Ben Kelly [:bkelly, not reviewing]]

Have we observed this problem v1.2?  The mozContact webidl changes are not being uplifted to v1.2, so I don't think this problem effects that branch.

Comment 11

[Noemí Freire (:noemi)]

Comment on attachment 825247 [details]
13257.html

(In reply to Ben Kelly [:bkelly] from comment #10)
> Have we observed this problem v1.2?  The mozContact webidl changes are not
> being uplifted to v1.2, so I don't think this problem effects that branch.

you are totally right, this issue is not occuring on v1.2 branch so removing v1.2 approval. Thanks for raise it!

Comment 12

[Joe Cheng [:jcheng] (please needinfo)]

remove blocking flag. this is already in master (1.3)