Closed Bug 931017 Opened 7 years ago Closed 7 years ago

Port FINAL_TARGET to moz.build in comm-central

Categories

(MailNews Core :: Build Config, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 27.0

People

(Reporter: jcranmer, Assigned: jcranmer)

References

Details

Attachments

(2 files)

No description provided.
Assignee: nobody → Pidgeot18
Attachment #822323 - Flags: review?(mbanner)
Surprisingly, this rebased cleanly after the recent build ontology changes. Huh.
Attachment #822324 - Flags: review?(mbanner)
Blocks: 930981
Comment on attachment 822323 [details] [diff] [review]
Part 1: Port moving backend.mk to config.mk

Review of attachment 822323 [details] [diff] [review]:
-----------------------------------------------------------------

Not tested, so consider testing on try server before landing. r=Standard8
Attachment #822323 - Flags: review?(mbanner) → review+
Comment on attachment 822324 [details] [diff] [review]
Part 2: Migrate FINAL_TARGET itself

Review of attachment 822324 [details] [diff] [review]:
-----------------------------------------------------------------

Again, not tested, so consider a try server run before landing. r=Standard8

::: config/config.mk
@@ +38,5 @@
>    ANDROID_RESFILES \
>    CMMSRCS \
>    CPP_UNIT_TESTS \
>    DIRS \
> +	DIST_SUBDIR \

Spaces versus tabs? (several places in this file, need to be made consistent).
Attachment #822324 - Flags: review?(mbanner) → review+
(In reply to Mark Banner (:standard8) from comment #3)
> Comment on attachment 822323 [details] [diff] [review]
> Part 1: Port moving backend.mk to config.mk
> 
> Review of attachment 822323 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Not tested, so consider testing on try server before landing. r=Standard8

This appears to break OS X universal builds, and only universal builds. Which makes no sense considering it's a straightforward port of m-c changes...
https://hg.mozilla.org/comm-central/rev/52b5c0b3d58c
https://hg.mozilla.org/comm-central/rev/6b60e35addee
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 27.0
(In reply to Joshua Cranmer [:jcranmer] from comment #5)
> This appears to break OS X universal builds, and only universal builds.
> Which makes no sense considering it's a straightforward port of m-c
> changes...

It turns out that calendar's flight.mk for the universal build needs to include config.mk, so I added a STANDALONE_MAKEFILE := 1 to that file and got it working.
Question regarding Bug 934013: Is there a way to use something like $(DIST) in moz.build in comm-central? Or should we hardcode "mozilla/dist" in such a case?
You need to log in before you can comment on or make changes to this bug.