931017 - Port FINAL_TARGET to moz.build in comm-central

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Comment 1

[Joshua Cranmer [:jcranmer]]

Attachment: Part 1: Port moving backend.mk to config.mk

Comment 2

[Joshua Cranmer [:jcranmer]]

Attachment: Part 2: Migrate FINAL_TARGET itself

Surprisingly, this rebased cleanly after the recent build ontology changes. Huh.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 822323 [details] [diff] [review]
Part 1: Port moving backend.mk to config.mk

Review of attachment 822323 [details] [diff] [review]:
-----------------------------------------------------------------

Not tested, so consider testing on try server before landing. r=Standard8

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 822324 [details] [diff] [review]
Part 2: Migrate FINAL_TARGET itself

Review of attachment 822324 [details] [diff] [review]:
-----------------------------------------------------------------

Again, not tested, so consider a try server run before landing. r=Standard8

::: config/config.mk
@@ +38,5 @@
>    ANDROID_RESFILES \
>    CMMSRCS \
>    CPP_UNIT_TESTS \
>    DIRS \
> +	DIST_SUBDIR \

Spaces versus tabs? (several places in this file, need to be made consistent).

Comment 5

[Joshua Cranmer [:jcranmer]]

(In reply to Mark Banner (:standard8) from comment #3)
> Comment on attachment 822323 [details] [diff] [review]
> Part 1: Port moving backend.mk to config.mk
> 
> Review of attachment 822323 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Not tested, so consider testing on try server before landing. r=Standard8

This appears to break OS X universal builds, and only universal builds. Which makes no sense considering it's a straightforward port of m-c changes...

Comment 6

[Joshua Cranmer [:jcranmer]]

https://hg.mozilla.org/comm-central/rev/52b5c0b3d58c
https://hg.mozilla.org/comm-central/rev/6b60e35addee

Comment 7

[Joshua Cranmer [:jcranmer]]

(In reply to Joshua Cranmer [:jcranmer] from comment #5)
> This appears to break OS X universal builds, and only universal builds.
> Which makes no sense considering it's a straightforward port of m-c
> changes...

It turns out that calendar's flight.mk for the universal build needs to include config.mk, so I added a STANDALONE_MAKEFILE := 1 to that file and got it working.

Comment 8

[Frank Wein [:mcsmurf]]

Question regarding Bug 934013: Is there a way to use something like $(DIST) in moz.build in comm-central? Or should we hardcode "mozilla/dist" in such a case?