931054 - [Camera] filmstrip.js tries to access undefined preview metadata

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Diego Marcos [:dmarcos]]

Filmstrip hash to call parseJPEGMetadata on the preview to retrieve its metadata.

Comment 1

[Mike Habicher [:mikeh] (high bugzilla latency)]

Should be hd+ because it blocks an hd+ bug.

Comment 2

[Diego Marcos [:dmarcos]]

Attachment: Github Pull Request

Comment 3

[Hema Koka [:hema]]

Moving to hd+ since the bug that this blocks is a hd blocker

Comment 4

[David Flanagan [:djf]]

Comment on attachment 822412 [details] [review]
Github Pull Request

r+, but see my comments on github:

1) Use + instead of \ for long strings

2) File another hd+ bug for adding devicePixelRatio in the various places it will be needed.  Once we get the embedded preview image size right, photos will look blurry on Helix unless we add devicePixelRatio support, so that new bug will have to block the same bug this one does.

Comment 5

[James Lal [:lightsofapollo]]

https://github.com/mozilla-b2g/gaia/commit/1ec3346f270c7395a6b863403edeec2d527cf7c9

lint errors and bunch of other red on ci- backed out above.

Comment 6

[Diego Marcos [:dmarcos]]

Attachment: Pull Request

Comment 7

[Diego Marcos [:dmarcos]]

Merged on master:

https://github.com/dmarcos/gaia/commit/35186c6785a77111fae6c64e8cada39a05493050

Comment 8

[Diego Marcos [:dmarcos]]

Attaching a patch that applies on v1.1hd. I need some help. I don't have a device to test it. lecky, can you give it a try?

Comment 9

[Diego Marcos [:dmarcos]]

Attachment: Patch for v1.1hd

Comment 10

[Diego Marcos [:dmarcos]]

I tested the patch for v.1.1hd and it works fine to me. I'm sending this for review.

Comment 11

[Diego Marcos [:dmarcos]]

Attachment: Pull request for v.1.1.0hd

Comment 12

[Diego Marcos [:dmarcos]]

Attached pull request specific to v.1.1.0hd. Need review for if

Comment 13

[David Flanagan [:djf]]

Setting the tracking flags, so this can be uplifted to v1.2 as well.

Diego: are there merge conflicts or can we just let a sheriff uplift this to the hd branch?

Also, comment 12 is incomplete... What do you want me to review for?

Comment 14

[Diego Marcos [:dmarcos]]

What's a sheriff uplift? The patch I created for master doesn't apply on v.1.1.0hd. The code has diverged.

Comment 15

[Diego Marcos [:dmarcos]]

I just need a review for the patch for v.1.1.0hd

https://github.com/mozilla-b2g/gaia/pull/13264

Comment 16

[David Flanagan [:djf]]

Comment on attachment 825442 [details] [review]
Pull request for v.1.1.0hd

The patch looks good to me. AFAIK, you don't generally need to request reviews for uplifts. I assume you've tried it out on the hd branch... And if it works, then go ahead and land.

Comment 17

[Diego Marcos [:dmarcos]]

Merged on v.1.1.0hd

https://github.com/mozilla-b2g/gaia/commit/355be5eebe5bb80f01d57076742c6e3beb8f8d0d

Merged on master:

https://github.com/mozilla-b2g/gaia/commit/35186c6785a77111fae6c64e8cada39a05493050

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Still needs merging to the v1.2 branch.

Comment 19

[Diego Marcos [:dmarcos]]

No it's merged on v.1.2 branch as well

https://github.com/dmarcos/gaia/commit/1d161d820058f25e0e6c8f5a74e6c3fb4a010bb1