Selecting 'Save As' for a received attachment in mail opens a dialog titled 'Save Attachment'. This title text appears to be coming from msgbase.dll and is therefore unlocalisable. Steps to Repro. 1. Launch mail and setup a valid account 2. Send this account a mail including an attachment 3 [details] [diff] [review]. Right click on the received mail and select 'Save As'
/mailnews/base/src/nsMessenger.cpp, line 395 -- NS_NAMED_LITERAL_STRING(saveAttachmentTag, "Save Attachment"); /mailnews/base/src/nsMessenger.cpp, line 685 -- GetString(NS_ConvertASCIItoUCS2("Save Attachment").get()),
Status: UNCONFIRMED → NEW
Ever confirmed: true
assigning to putterman, cc mscott,yokoyama
Assignee: yokoyama → putterman
MScott is this one gonna be fixed any time soon (i.e. TM0.9.4)?
Marking nsbranch- as it was decided in the August bug triage that we wouldn't have enough time in eMojo to fix this. Let's revisit for MachV.
removed keyword nsbranch since bug now has nsbranch-, per pdt mtg.
reassigning to ssu
Assignee: putterman → ssu
Nominating for nsbeta1.
*** Bug 108602 has been marked as a duplicate of this bug. ***
need to do "Save All Attachments" as well.
Summary: 'Save Attchment' dialog title located in msgbase.dll → 'Save Attachment' dialogs title located in msgbase.dll
Keywords: nsbeta1+ → nsbeta1-
Target Milestone: mozilla1.0 → mozilla1.2
Both "Save attachment" and "Save all attachments" are hardcoded in: mailnews/base/src/nsMessenger.cpp ji, is this for Windows only? Looks Mac has same problem...
This problem exists for all the platforms.
Hardware: PC → All
Created attachment 71949 [details] [diff] [review] use StringBundle to retrieve texts in messenger.properties sean: Attached should fix your problem.
Michele, since this has a patch already, should we mark this as nsbeta1+? This is kind of critical for l10n.
Comment on attachment 71949 [details] [diff] [review] use StringBundle to retrieve texts in messenger.properties thanks for the patch Roy. r=ssu looking for sr= now.
Attachment #71949 - Flags: review+
Comment on attachment 71949 [details] [diff] [review] use StringBundle to retrieve texts in messenger.properties sr=mscott
Attachment #71949 - Flags: superreview+
Keywords: nsbeta1- → nsbeta1+
Comment on attachment 71949 [details] [diff] [review] use StringBundle to retrieve texts in messenger.properties a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #71949 - Flags: approval+
roy's patch checked in to trunk only.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
ji, you can verify this bug now. I just tested 02-03-07 trunk, by modifying the file in language pack, "Save attachment" and "Save all attachment" can be easily localized like Japanese.
Marked it as verified. Ying, thanks for the help.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.