93107 - 'Save Attachment' dialogs title located in msgbase.dll

Status: VERIFIED FIXED

(MailNews Core :: Internationalization, defect, P2)

Description

[Anna Cassidy]

Selecting 'Save As' for a received attachment in mail opens a dialog titled
'Save Attachment'. This title text appears to be coming from msgbase.dll and is
therefore unlocalisable. 


Steps to Repro.
1.  Launch mail and setup a valid account
2.  Send this account a mail including an attachment
3 [details] [diff] [review].  Right click on the received mail and select 'Save As'

Comment 1

[nhottanscp]

/mailnews/base/src/nsMessenger.cpp, line 395 --
NS_NAMED_LITERAL_STRING(saveAttachmentTag, "Save Attachment");
/mailnews/base/src/nsMessenger.cpp, line 685 --
GetString(NS_ConvertASCIItoUCS2("Save Attachment").get()),

Comment 2

[Roy Yokoyama]

assigning to putterman, cc mscott,yokoyama

Comment 3

[Jaime Rodriguez, Jr.]

MScott is this one gonna be fixed any time soon (i.e. TM0.9.4)?

Comment 4

[Cindy Roberts]

Marking nsbranch- as it was decided in the August bug triage that we wouldn't
have enough time in eMojo to fix this.  Let's revisit for MachV.

Comment 5

[elaineking]

removed keyword nsbranch since bug now has nsbranch-, per pdt mtg.

Comment 6

[scottputterman]

reassigning to ssu

Comment 7

[ji]

Nominating for nsbeta1.

Comment 8

[scottputterman]

*** Bug 108602 has been marked as a duplicate of this bug. ***

Comment 9

[scottputterman]

need to do "Save All Attachments" as well.

Comment 10

[Ying-Lin Xia]

Both "Save attachment" and "Save all attachments" are hardcoded in:
mailnews/base/src/nsMessenger.cpp

ji, is this for Windows only? Looks Mac has same problem...

Comment 11

[ji]

This problem exists for all the platforms. 

Comment 12

[Roy Yokoyama]

Attachment: use StringBundle to retrieve texts in messenger.properties

sean: Attached should fix your problem.

Comment 13

[Ying-Lin Xia]

Michele, since this has a patch already, should we mark this as nsbeta1+? This 
is kind of critical for l10n.

Comment 14

[Sean Su]

Comment on attachment 71949 [details] [diff] [review]
use StringBundle to retrieve texts in messenger.properties

thanks for the patch Roy.
r=ssu

looking for sr= now.

Comment 15

[Scott MacGregor]

Comment on attachment 71949 [details] [diff] [review]
use StringBundle to retrieve texts in messenger.properties

sr=mscott

Comment 16

[Michele Carlson]

marked nsbeta1+

Comment 17

[Asa Dotzler [:asa]]

Comment on attachment 71949 [details] [diff] [review]
use StringBundle to retrieve texts in messenger.properties

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 18

[Sean Su]

roy's patch checked in to trunk only.

Comment 19

[Ying-Lin Xia]

ji, you can verify this bug now. I just tested 02-03-07 trunk, by modifying the 
file in language pack, "Save attachment" and "Save all attachment" can be 
easily localized like Japanese.

Comment 20

[ji]

Marked it as verified. Ying, thanks for the help.