931071 - Desktop talos runs don't clean up the local minidump directory, unlike mobile

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Ed Morley [:emorley]]

Broken out from bug 931032:

(In reply to Ed Morley [:edmorley UTC+1] from bug 931032 comment #12)
> Side note:
> Strange how we clear up the local directory in the Android case, but not
> desktop. Is this intentional?

(In reply to Joel Maher (:jmaher) from comment #14)
> we really should clear up the local directory in the desktop case, that
> isn't intentional

Comment 1

[Ed Morley [:emorley]]

On mobile:
https://hg.mozilla.org/build/talos/file/608228e6477f/talos/ttest.py#l170
   158                 # check for minidumps
   159                 minidumpdir = tempfile.mkdtemp()
   160                 try:
   161                     if self._ffprocess.testAgent.dirExists(remoteminidumpdir):
   162                         self._ffprocess.testAgent.getDirectory(remoteminidumpdir, minidumpdir)
   163                 except mozdevice.DMError:
   164                     print "Remote Device Error: Error getting crash minidumps from device"
   165                     raise
   166                 found = mozcrash.check_for_crashes(minidumpdir,
   167                                                    browser_config['symbols_path'],
   168                                                    stackwalk_binary=stackwalkbin,
   169                                                    test_name=test_name)
   170                 self._hostproc.removeDirectory(minidumpdir)

On desktop:
https://hg.mozilla.org/build/talos/file/608228e6477f/talos/ttest.py#l175
   174         else:
   175             # check for minidumps
   176             minidumpdir = os.path.join(profile_dir, 'minidumps')
   177             found = mozcrash.check_for_crashes(minidumpdir,
   178                                                browser_config['symbols_path'],
   179                                                stackwalk_binary=stackwalkbin,
   180                                                test_name=test_name)

Comment 2

[Vaibhav (:vaibhav1994)]

Can I take up this bug?

Comment 3

[Vaibhav (:vaibhav1994)]

Attachment: minidump.patch

This takes care of cleaning up minidumps directory.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8370762 [details] [diff] [review]
minidump.patch

Review of attachment 8370762 [details] [diff] [review]:
-----------------------------------------------------------------

ok, that was simple!

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

in talos repo- will pick it up when we update talos in the future.
https://hg.mozilla.org/build/talos/rev/5b82097d719d

Comment 6

[Ed Morley [:emorley]]

Vaibhav - thank you for the patch! :-)