Closed Bug 931105 Opened 7 years ago Closed 7 years ago

truncate descriptions on dashboard

Categories

(Input Graveyard :: Dashboard, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

Details

(Whiteboard: u=user c=dashboard p=1 s=input.2013q4)

Feedback response descriptions can have immense lengths. At some point, someone requested that we truncate the descriptions at like 500 characters so the dashboard page isn't crazy. For some reason, some of that code was written, but not completed.
I contend that we should:

1. truncate the feedback response descriptions on the dashboard page to like 500 characters

2. if you click on the permalink for a response, the response details page should show the full description (it does this currently--we wouldn't change this)



Two questions:

1. Should we go ahead with this? (I think yes.)

2. Is 500 characters a good truncation length? (I did some poking around and think yes.)


This is a trivial change and we can easily tweak the truncation length later if we want to change it or undo it.
OS: Linux → All
Priority: -- → P3
Hardware: x86_64 → All
Whiteboard: u=user c=dashboard p=0 s=input.2013q4
This is an easy change. It'd make the main dashboard page less crazy when we have those huge responses.

If I don't hear anything back on this, I'll push it off to next quarter.
Flags: needinfo?(mgrimes)
Hey Will. This looks great. Please proceed as you've described above.
Flags: needinfo?(mgrimes)
Grabbing this since I'm working on it.
Assignee: nobody → willkg
Status: NEW → ASSIGNED
Landed in master in https://github.com/mozilla/fjord/commit/d0005ab

Pushed to prod just now.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: u=user c=dashboard p=0 s=input.2013q4 → u=user c=dashboard p=1 s=input.2013q4
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.