[es-ES] Add Yahoo! and Bing to Fennec search engines

RESOLVED FIXED in Firefox 26

Status

Mozilla Localizations
es-ES / Spanish
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: gueroJeff, Assigned: RickieES aka Ricardo Palomares)

Tracking

({productization})

unspecified
mozilla26
ARM
Android
productization
Dependency tree / graph

Firefox Tracking Flags

(firefox26+ fixed, firefox27 fixed, firefox28 fixed)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
As discussed previously via email, please proceed to add Yahoo! and Bing to your locale's list of search engines.

Here are the instructions to do so:

For Yahoo!
- Following the guide of the en-US patch in bug 903082, please create an XML search plugin for Yahoo! and add Yahoo! to list.txt

For Bing
- Please add Bing to your list of search plugins on list.txt

Ordering:
- Please order these new search engines as follows in region.properties
1) Google
2) Yahoo!
3) Bing

As discussed before, these changes should only be seen by new users of the app and will not impact existing users. In addition, changes to the UI in Firefox 26 support the user's ability to easily change their default search engines. The link to that feature can be found in the URL field below.

Thank you for your help and understanding. As this is aimed at Firefox 26, please notify me once you have been able to have this patch approved and landed in your Aurora repos and signed-off. I will quickly approve the sign-off to ensure this is included in Firefox 26 before migration occurs.

I apologize for how late this is coming, we were only able to confirm these details today. Thank you for your participation and help with this!
(Reporter)

Updated

4 years ago
status-firefox26: --- → ?
tracking-firefox26: --- → ?
Keywords: productization
Target Milestone: --- → mozilla26
(Reporter)

Updated

4 years ago
Blocks: 903084
(Assignee)

Updated

4 years ago
OS: Mac OS X → Android
Hardware: x86 → ARM
(Assignee)

Comment 1

4 years ago
Can we use this bug to also remove obsolete / useless searchplugins too? We'd like to remove 11870 and Twitter searchplugins, based on this rationale:

- 11870 is a kind of yellow pages for going out (restaurants, pubs, theaters, movies, museums...) and shopping. Nowadays, it is easier to get directions from Google Maps for quick searches, and 11870 provides its own app for Android which allows to comment and score places in a more comfortable way.

- Twitter app is shipped in most Android mobiles and, for searches, it is not needed to use Twitter search engine to get results from Twitter: Google indexes Twitter pages, too.

If you prefer to separate this in other bug, there is no problem.

BTW, I've added a comment in bug 903082 because the changes in en-US are not applied to Aurora, just Central.

Also, I'm having problems locating my user data in Android, so I can test the change without having to build Fennec myself (which, honestly, I don't know how to do). I'd be happy to get pointers to user profile location on Android (nothing found on MDN so far).
(Assignee)

Comment 2

4 years ago
I've asked in bug 903082 (comment #47) whether we (localizations) must be after en-US or can land already, among other things. Besides, there is my question in comment #1 above. Just let me know if you're waiting for me. :-)
Flags: needinfo?(jbeatty)
(Reporter)

Comment 3

4 years ago
(In reply to Ricardo Palomares from comment #1)
> Can we use this bug to also remove obsolete / useless searchplugins too?
> We'd like to remove 11870 and Twitter searchplugins, based on this rationale:
> 
> - 11870 is a kind of yellow pages for going out (restaurants, pubs,
> theaters, movies, museums...) and shopping. Nowadays, it is easier to get
> directions from Google Maps for quick searches, and 11870 provides its own
> app for Android which allows to comment and score places in a more
> comfortable way.
> 
> - Twitter app is shipped in most Android mobiles and, for searches, it is
> not needed to use Twitter search engine to get results from Twitter: Google
> indexes Twitter pages, too.
> 
> If you prefer to separate this in other bug, there is no problem.

TBH, I would prefer to separate this into another bug. The Fennec team is tracking these specific additions closely and I'd rather not add more noise than necessary to it.
> 
> BTW, I've added a comment in bug 903082 because the changes in en-US are not
> applied to Aurora, just Central.
I saw that, thank you for pointing it out.
> 
> Also, I'm having problems locating my user data in Android, so I can test
> the change without having to build Fennec myself (which, honestly, I don't
> know how to do). I'd be happy to get pointers to user profile location on
> Android (nothing found on MDN so far).
This I'm entirely unfamiliar with. Your best bet will likely be on #l10n, the dev-l10n newsgroup, or even #mobile.
Flags: needinfo?(jbeatty)
(Reporter)

Comment 4

4 years ago
(In reply to Ricardo Palomares from comment #2)
> I've asked in bug 903082 (comment #47) whether we (localizations) must be
> after en-US or can land already, among other things. Besides, there is my
> question in comment #1 above. Just let me know if you're waiting for me. :-)

Because the default for Bing is the en-US site and the locale redirect happens there, it's best to wait for en-US to land. I know they're also working on uptreaming the landing to Beta, since this is all aimed at inclusion into FF26. I believe Lassey has added some comments to your comment in that bug too.
status-firefox26: ? → affected
status-firefox27: --- → affected
status-firefox28: --- → affected
tracking-firefox26: ? → +
(Assignee)

Comment 5

4 years ago
Created attachment 826057 [details] [diff] [review]
Patch adding Yahoo and Bing to Firefox Mobile

The patch is created in l10n-mozilla-aurora, but it will work in Beta channel too, as the affected files are equal.

Regarding the "\ No newline at the end of the file", it is a message because the current list.txt file does not end with a 0x0A byte (new line), but after modifying it with a regular text editor, the byte is added even if you can't put the cursor visually in a new line.

I can remove the extra 0x0A byte, but it involves removing the last visual character of the file with the text editor and then using an hex editor to manually add the remaining character. As the usual procedure for modifying this kind of files is using a text editor, I think it is better to let it introduce the additional byte now and forever.
Attachment #826057 - Flags: review?(jbeatty)
(Reporter)

Comment 6

4 years ago
Comment on attachment 826057 [details] [diff] [review]
Patch adding Yahoo and Bing to Firefox Mobile

Changing review flag to Flod
Attachment #826057 - Flags: review?(jbeatty) → review?(francesco.lodolo)
(Assignee)

Comment 7

4 years ago
(In reply to jbeatty from comment #3)
> (In reply to Ricardo Palomares from comment #1)
> > Can we use this bug to also remove obsolete / useless searchplugins too?
> > We'd like to remove 11870 and Twitter searchplugins, based on this rationale:
> TBH, I would prefer to separate this into another bug. The Fennec team is
> tracking these specific additions closely and I'd rather not add more noise
> than necessary to it.


OK, I will double-check with es-ES mailing list, because I honestly have doubts about removing 11870, and will file a separate bug once we're clear and set.


> > Also, I'm having problems locating my user data in Android, so I can test
> > the change without having to build Fennec myself (which, honestly, I don't
> > know how to do). I'd be happy to get pointers to user profile location on
> > Android (nothing found on MDN so far).
> This I'm entirely unfamiliar with. Your best bet will likely be on #l10n,
> the dev-l10n newsgroup, or even #mobile.


Just so you know, ;-) too, flod has pointed me to a page that says that every Android app saves its data inside the /data/data directory (so, internal storage of the device, directory 'data'), in a directory named after the application package name (like org.mozilla.firefox). However, the /data/data directory is not accessible to users unless the device has been rooted.
(Reporter)

Comment 8

4 years ago
(In reply to Ricardo Palomares from comment #7)
> (In reply to jbeatty from comment #3)
> > (In reply to Ricardo Palomares from comment #1)
> > > Can we use this bug to also remove obsolete / useless searchplugins too?
> > > We'd like to remove 11870 and Twitter searchplugins, based on this rationale:
> > TBH, I would prefer to separate this into another bug. The Fennec team is
> > tracking these specific additions closely and I'd rather not add more noise
> > than necessary to it.
> 
> 
> OK, I will double-check with es-ES mailing list, because I honestly have
> doubts about removing 11870, and will file a separate bug once we're clear
> and set.
> 
> 
> > > Also, I'm having problems locating my user data in Android, so I can test
> > > the change without having to build Fennec myself (which, honestly, I don't
> > > know how to do). I'd be happy to get pointers to user profile location on
> > > Android (nothing found on MDN so far).
> > This I'm entirely unfamiliar with. Your best bet will likely be on #l10n,
> > the dev-l10n newsgroup, or even #mobile.
> 
> 
> Just so you know, ;-) too, flod has pointed me to a page that says that
> every Android app saves its data inside the /data/data directory (so,
> internal storage of the device, directory 'data'), in a directory named
> after the application package name (like org.mozilla.firefox). However, the
> /data/data directory is not accessible to users unless the device has been
> rooted.
Thanks for the info! I've spent the last two days working on rooting devices. It's no fun at all :-(
Comment on attachment 826057 [details] [diff] [review]
Patch adding Yahoo and Bing to Firefox Mobile

Review of attachment 826057 [details] [diff] [review]:
-----------------------------------------------------------------

Please provide a patch without suggestions and we're good to go.

::: mobile/searchplugins/yahoo-es.xml
@@ +6,5 @@
> +<ShortName>Yahoo</ShortName>
> +<InputEncoding>UTF-8</InputEncoding>
> +<Image width="16" height="16">data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAAEJGlDQ1BJQ0MgUHJvZmlsZQAAOBGFVd9v21QUPolvUqQWPyBYR4eKxa9VU1u5GxqtxgZJk6XtShal6dgqJOQ6N4mpGwfb6baqT3uBNwb8AUDZAw9IPCENBmJ72fbAtElThyqqSUh76MQPISbtBVXhu3ZiJ1PEXPX6yznfOec7517bRD1fabWaGVWIlquunc8klZOnFpSeTYrSs9RLA9Sr6U4tkcvNEi7BFffO6+EdigjL7ZHu/k72I796i9zRiSJPwG4VHX0Z+AxRzNRrtksUvwf7+Gm3BtzzHPDTNgQCqwKXfZwSeNHHJz1OIT8JjtAq6xWtCLwGPLzYZi+3YV8DGMiT4VVuG7oiZpGzrZJhcs/hL49xtzH/Dy6bdfTsXYNY+5yluWO4D4neK/ZUvok/17X0HPBLsF+vuUlhfwX4j/rSfAJ4H1H0qZJ9dN7nR19frRTeBt4Fe9FwpwtN+2p1MXscGLHR9SXrmMgjONd1ZxKzpBeA71b4tNhj6JGoyFNp4GHgwUp9qplfmnFW5oTdy7NamcwCI49kv6fN5IAHgD+0rbyoBc3SOjczohbyS1drbq6pQdqumllRC/0ymTtej8gpbbuVwpQfyw66dqEZyxZKxtHpJn+tZnpnEdrYBbueF9qQn93S7HQGGHnYP7w6L+YGHNtd1FJitqPAR+hERCNOFi1i1alKO6RQnjKUxL1GNjwlMsiEhcPLYTEiT9ISbN15OY/jx4SMshe9LaJRpTvHr3C/ybFYP1PZAfwfYrPsMBtnE6SwN9ib7AhLwTrBDgUKcm06FSrTfSj187xPdVQWOk5Q8vxAfSiIUc7Z7xr6zY/+hpqwSyv0I0/QMTRb7RMgBxNodTfSPqdraz/sDjzKBrv4zu2+a2t0/HHzjd2Lbcc2sG7GtsL42K+xLfxtUgI7YHqKlqHK8HbCCXgjHT1cAdMlDetv4FnQ2lLasaOl6vmB0CMmwT/IPszSueHQqv6i/qluqF+oF9TfO2qEGTumJH0qfSv9KH0nfS/9TIp0Wboi/SRdlb6RLgU5u++9nyXYe69fYRPdil1o1WufNSdTTsp75BfllPy8/LI8G7AUuV8ek6fkvfDsCfbNDP0dvRh0CrNqTbV7LfEEGDQPJQadBtfGVMWEq3QWWdufk6ZSNsjG2PQjp3ZcnOWWing6noonSInvi0/Ex+IzAreevPhe+CawpgP1/pMTMDo64G0sTCXIM+KdOnFWRfQKdJvQzV1+Bt8OokmrdtY2yhVX2a+qrykJfMq4Ml3VR4cVzTQVz+UoNne4vcKLoyS+gyKO6EHe+75Fdt0Mbe5bRIf/wjvrVmhbqBN97RD1vxrahvBOfOYzoosH9bq94uejSOQGkVM6sN/7HelL4t10t9F4gPdVzydEOx83Gv+uNxo7XyL/FtFl8z9ZAHF4bBsrEwAAAAlwSFlzAAALEwAACxMBAJqcGAAAByVJREFUWAm1l1uIldcVx9d3ruMZZzRaay+pCjFJH6LSRqxQqA1NH0pBiH3Qp774kEAg4EOkxKdQSCjUFvpm6YsNVNoSaGjFtmga2yZgCIIawdv04g2kM7Uz6lzO+c758v/t/9lzTB/61Oxhn7332muv9V+3vb8pnooDVRkzZ4oY/LmK6mQZa05frX6yFJ9Ae7x4qd2IuV1FFM9WMfhaI9Z+pQBAL+aiEZ0QgNBm2YuZmxHF9VZMXqmivFaLweUyuteWYvHGVPWr2f+F7YvF/ola9DZGVJsHUXs8YvBEK1ZrXt9URDwqxY1BdGMQvWjGqkgA+iLUtazHuADUoowHYugKTilaR7SIpZjWqOMRfY090RbasS4JglpFtzWIcqwZa+pSqnWVcLLXijXpZCFpvbgb/VhMe8huMLPylWkci8/oSD8xJq7hj4WUWvXrlbqVrUyKtBYdpX3Bh9YbzsdErwRgbZKyFP+KdqxPssu4l2hDAOOxIj6bCHigKWRNCcpMCHHHB4TJLc+TXxKHnC51Ct+Qgxl/TZ0qE5Be/EdWTwjqQuJJAPIB8qAZk4kZoXJnvHH+27Hq0+0YX12PH+w7E3/8zbWkitN2M8pS7kCKZ761OV55c2fcm+nG7J1e7N/+e3m2nbyKQcAhnHWZLC86B1rxiFRvSIkIgJHFVWzZ+qk4fG5HEr4wV8buVb+Vuv5QeVZsi/HeW//eHZ1HbNfLT5+Jc2dndBav9KXugfqc+pLsv6Xxvk6kVheumnpDnXlTVMZWfHh+Li6cdOKvmGzEC69+WTskzwr1SfUJ9ZWp7z/0pWXlF9+ejQtnUdCWnAxQ+al5Tdz80lIVEP8x9eZQWCQwOTAhNc34Re+rUW8U0S+r2Ns8nWzBKgONBOeX3V3RaCpPRN7XeFcO7yYl+InML2U3VdBVHszHzbSXYLBJkuTSQzBuphoYZ7X/u8O30gFAHHxzi+Yop8ETcfDXW5JyKMd/fFuO9l3mYuwLAl5gbMg8QuKdYQg4Zjcxo7HikMeIn37vcizes9Ide9bGhs9NLPN9YX0ndnzHpbZ4vx9HXr6kc6Sobo2hIkuzOnIh0xMFRlvc0waWL+p3UePCQ/Myjjx/JSnl59CJbUkJgl75g+ZD/D978Yrc7EuMPe4ESo6OYsaasiiX7tADAyny5cGtyMHsDxzFnP0Tx6Z0SfsW27B1PHZ+c13seGZdbNo2Lo6Iu7e7cfznfxc/8ggNQBhZI9dSs2c5k+rFaHBXmZhd32xTGdlZPvzDvefj9XddlgeObYVpuf1o3zkpyrEnCJwBDjlmr9i7XP3jgrYkDamhEqRA8UOBxZ53tcOtBbgyzr53M65f8DU6sVZ1o067cfFBvP+XGzrDOa5s+JkTShIc+dBtlLOLlRpqAUDc+yqQMnViNq81edDVnPixno/vP/dXjn2svbbnPa1RiqXEHVkYQ06RWygnFEtpbZDLAJws2X1OHgfCv+hiRkZU8Y+pmbjwzjTE1D48PR1TV+5IMErgsjex2A8TJrqCHH9Cw6U0BGBkPUWrKTZnPq4L9WqIOFvEO8ml+vbRvyUB/Jw6OiUa9GydM58qQl6lTrNHyiENrwyTkOvXLziVkMlOOsesVKyIFtZB1zfDAGvdyj4xtkD7yHQ8Ynn4hCrwvYA+DOJCSlXAZl3MjNQobNzVPK7gJm0AiPsQyEg0c6s1cbEB5X08AmDz1TTLucApzHHyJgADvUqVysJMKOSicLRQl+emOIvbnaw+ot2pSTzl5zzJVjPaZ6ix7zCSN4E1shOAWnqbyYH8bOqd1h9AGJ0qtl6LRBubcBKxbo6xh60kWlbLjgG4NJ2ETkwqbl7SeUXVSCq+BF1C2bWEgEO4CxBGvOydGmu3ooXv7AEogLFqn2JtWKO8yc9xAmDxjhGiWMOQXe63zCvHtIjOpGOIwvGJlhRQepyzaiu0MQ4MnFhuT7CiJQC+sUg4jtOYO+1IH9OdCwgBSmOkP2r60CarHeXMjxw3PGyvOBnN670EgOPOc1yEYgDYCxbqTPDXki1srChi4R6lpQ+uDmVFDtkA5GH1qJEvQFgacqCFT37pyP+Y+DMJs0Y54NgbiIVn61jhEUrNARuNIi3vOQf8iUeQuNzILe4b/jFZ7RDYJhTbVRaJTxyWh8PgO93hQJCBsSa2GQyyoLlBzWDxgnm9l0JgADgNgVxElCH22xs4NCsaieSUyzWXaSTLDAPlGQB0Kt6JaqpzYjkJQT9id60aNwqZjVqlz9Kqp+JcfDjOAqhirNoCI6MelpVPAjZ/CbFv45Y9YNcicqDMKm/Xo/FPJdMlqZ9SIK7qSrrci9mbl6q3/DGQ5f7XuK347rgKeuMgiicEfLPmT0rGY1K5SdI/ryritlMbJrr/PZ8+I8qf9PF8qhMrT39QHfHLkhj/fz/bi+eb83F/VxX1b6jWvt6KdTs/AvvCmqXE235jAAAAAElFTkSuQmCC</Image>
> +<Url type="application/x-suggestions+json" method="GET"
> +     template="http://ff.search.yahoo.com/gossip?output=fxjson&amp;command={searchTerms}" />

Let's drop suggestions for now (bug 903082 comment 48).
Attachment #826057 - Flags: review?(francesco.lodolo) → review-
(Assignee)

Comment 10

4 years ago
Created attachment 826306 [details] [diff] [review]
Patch adding Yahoo (without search suggestions) and Bing to Firefox Mobile

Something like this, I guess?
Attachment #826057 - Attachment is obsolete: true
Attachment #826306 - Flags: review?(francesco.lodolo)
Comment on attachment 826306 [details] [diff] [review]
Patch adding Yahoo (without search suggestions) and Bing to Firefox Mobile

Review of attachment 826306 [details] [diff] [review]:
-----------------------------------------------------------------

Exactly :-)

Please commit with a reference to this bug and review (r=flod). 
At this point you need to land this from mozilla-beta down to l10n-central
Attachment #826306 - Flags: review?(francesco.lodolo) → review+
status-firefox26: affected → fixed
status-firefox27: affected → fixed
status-firefox28: affected → fixed
You need to log in before you can comment on or make changes to this bug.