931216 - Convert deprecated octal literals in app update xpcshell tests

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

We should be able to just prefix them with 0o

http://mxr.mozilla.org/mozilla-central/source/modules/libjar/zipwriter/test/unit/test_zippermissions.js#56

http://mozilla.6506.n7.nabble.com/Octal-literals-have-their-uses-you-Unix-haters-skip-this-one-td107754.html

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 2

[Robert Strong (they/them - no direct email)]

Also, http://whereswalden.com/2013/08/12/micro-feature-from-es6-now-in-firefox-aurora-and-nightly-binary-and-octal-numbers/

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 4

[Robert Strong (they/them - no direct email)]

Comment on attachment 822605 [details] [diff] [review]
patch rev1

Try server pushes
linux debug and opt
https://tbpl.mozilla.org/?tree=Try&rev=ad251b0f9bab

mac and win opt
https://tbpl.mozilla.org/?tree=Try&rev=7ffc88a33b77

Comment 5

[Robert Strong (they/them - no direct email)]

forgot to include that 0o was added in bug 894026

Comment 6

[Brian R. Bondy [:bbondy]]

Comment on attachment 822605 [details] [diff] [review]
patch rev1

Review of attachment 822605 [details] [diff] [review]:
-----------------------------------------------------------------

You don't need the 0 prefix after the 0o, but if you really want it, that's fine with me.

Comment 7

[Robert Strong (they/them - no direct email)]

Attachment: patch rev2 - remove extraneous 0

carrying forward r+

Comment 8

[Robert Strong (they/them - no direct email)]

Pushed to fx-team
https://hg.mozilla.org/integration/fx-team/rev/33f2f1637653

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/33f2f1637653