93128 - offline: 'Undo delete messages' doesn't work when in offline mode

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Backend, defect)

Description

[grylchan]

comercial trunk build
2001073103 NT 4.0
2001073108 linux 2.2
2001073108 mac 9.0.4

If you go offline, delete a message, then try to undo
the deletion, you are not able to.

Steps to reproduce:
1.Login to your imap mail account
2.Go offline (doesn't matter whether you download a message or not
  as either type of message has the same behavior)
3.Delete a message (downloaded or non-downloaded)
4.Go to the menu: Edit|Undo 

Result: The menu item 'undo' or 'undo deleted messages' is not
        available. 'Redo deleted message' is available.
Expected: 'Undo' to be available if you are offline which will
          result in a message not being deleted.

If online, it works as expected.

Comment 1

[Oliver Klee]

Adding dataloss keyword.

Comment 2

[David :Bienvenu]

this is close to working in my tree - the undo delete works, but it's not
reflected in the UI (so you don't see the undeleted message reappear, but when
you go back online, the undeleted message shows up).

Comment 3

[David :Bienvenu]

Attachment: proposed fix

Comment 4

[David :Bienvenu]

Navin and Seth, can I get reviews? Basically, I had to implement this feature,
remove old 4.x ifdeffed out code, and implement new 6.x code.

Comment 5

[Navin Gupta]

Can we undo move/copy an offline imap msg to pop/local or vice-versa. 
Also have you tested for various imap delete models. 

Comment 6

[David :Bienvenu]

I only tested undo delete, which is what this bug is about. I haven't tried the
other delete models. If they don't work, I'll file new bugs.

Comment 7

[Navin Gupta]

ok, r=naving

Comment 8

[(not reading, please use [e-mail] instead)]

sr=sspitzer assuming that the undo manager deletes the txns you are creating 
(with new).

Comment 9

[David :Bienvenu]

Once I fixed the general leak of all undo transactions, I verified that the new
imap offline undo transactions don't leak (see bug 96564)

Comment 10

[David :Bienvenu]

Once I fixed the general leak of all undo transactions, I verified that the new
imap offline undo transactions don't leak (see bug 96564)

Comment 11

[Asa Dotzler [:asa]]

a=asa on behalf of drivers

Comment 12

[David :Bienvenu]

fix checked in.

Comment 13

[grylchan]

Commercial builds
2001082803 - win nt 4.0
2001082808 - linux 2.2, mac 9.0.4

Verified, in both themes, that if you delete
a message while offline (either downloaded/non-downloaded),
you can undo this by going to Edit|Undo and it will
undo the deletion.

Tested move also and you can undo a move command also.

Tested undoing a delete/move on webmail and pop accounts and it works
on those accounts to.

Only problem is the bug David already has filed, bug 96631

marking as verified.