Closed Bug 931345 Opened 6 years ago Closed 6 years ago

Remove on OS X the Print Preview in AppMenu

Categories

(Thunderbird :: OS Integration, defect)

All
macOS
defect
Not set

Tracking

(thunderbird26 fixed, thunderbird27 fixed, thunderbird_esr2426+ fixed)

RESOLVED FIXED
Thunderbird 28.0
Tracking Status
thunderbird26 --- fixed
thunderbird27 --- fixed
thunderbird_esr24 26+ fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

On OS X the print preview is in print dialog embedded and don't need a special menu item for it. The AppMenu has this item also on OS X.
Attached patch patchSplinter Review
Remove it on OS X
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #822729 - Flags: review?(bwinton)
Comment on attachment 822729 [details] [diff] [review]
patch

Review of attachment 822729 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me!

Thanks,
Blake.
Attachment #822729 - Flags: review?(bwinton) → review+
Keywords: checkin-needed
Comment on attachment 822729 [details] [diff] [review]
patch

[Approval Request Comment]
User impact if declined: The user has a dialog he don't need on OS X
Risk to taking this patch (and alternatives if risky): Low, it's only added a preprocessor rule to hide a menuentry on OS X
Attachment #822729 - Flags: approval-mozilla-esr24?
Attachment #822729 - Flags: approval-comm-aurora?
Comment on attachment 822729 [details] [diff] [review]
patch

Wrong approval flag chosen.
Attachment #822729 - Flags: approval-mozilla-esr24? → approval-comm-esr24?
https://hg.mozilla.org/comm-central/rev/0ae2fe7ca0a1
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 28.0
Comment on attachment 822729 [details] [diff] [review]
patch

[Triage Comment]
a=Standard8
Attachment #822729 - Flags: approval-comm-esr24?
Attachment #822729 - Flags: approval-comm-esr24+
Attachment #822729 - Flags: approval-comm-beta+
Attachment #822729 - Flags: approval-comm-aurora?
Attachment #822729 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.