Closed
Bug 931345
Opened 11 years ago
Closed 11 years ago
Remove on OS X the Print Preview in AppMenu
Categories
(Thunderbird :: OS Integration, defect)
Tracking
(thunderbird26 fixed, thunderbird27 fixed, thunderbird_esr2426+ fixed)
RESOLVED
FIXED
Thunderbird 28.0
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(1 file)
1.18 KB,
patch
|
bwinton
:
review+
standard8
:
approval-comm-aurora+
standard8
:
approval-comm-beta+
standard8
:
approval-comm-esr24+
|
Details | Diff | Splinter Review |
On OS X the print preview is in print dialog embedded and don't need a special menu item for it. The AppMenu has this item also on OS X.
Assignee | ||
Comment 1•11 years ago
|
||
Remove it on OS X
Comment 2•11 years ago
|
||
Comment on attachment 822729 [details] [diff] [review] patch Review of attachment 822729 [details] [diff] [review]: ----------------------------------------------------------------- rs=me! Thanks, Blake.
Attachment #822729 -
Flags: review?(bwinton) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 822729 [details] [diff] [review] patch [Approval Request Comment] User impact if declined: The user has a dialog he don't need on OS X Risk to taking this patch (and alternatives if risky): Low, it's only added a preprocessor rule to hide a menuentry on OS X
Attachment #822729 -
Flags: approval-mozilla-esr24?
Attachment #822729 -
Flags: approval-comm-aurora?
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 822729 [details] [diff] [review] patch Wrong approval flag chosen.
Attachment #822729 -
Flags: approval-mozilla-esr24? → approval-comm-esr24?
Comment 5•11 years ago
|
||
https://hg.mozilla.org/comm-central/rev/0ae2fe7ca0a1
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 28.0
Comment 6•11 years ago
|
||
Comment on attachment 822729 [details] [diff] [review] patch [Triage Comment] a=Standard8
Attachment #822729 -
Flags: approval-comm-esr24?
Attachment #822729 -
Flags: approval-comm-esr24+
Attachment #822729 -
Flags: approval-comm-beta+
Attachment #822729 -
Flags: approval-comm-aurora?
Attachment #822729 -
Flags: approval-comm-aurora+
Comment 7•11 years ago
|
||
https://hg.mozilla.org/releases/comm-aurora/rev/abaa064a70ad https://hg.mozilla.org/releases/comm-beta/rev/1e1ac9ac584a
status-thunderbird26:
--- → fixed
status-thunderbird27:
--- → fixed
tracking-thunderbird_esr24:
--- → 26+
Comment 8•11 years ago
|
||
https://hg.mozilla.org/releases/comm-esr24/rev/19a3ea7aadce
status-thunderbird_esr24:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•