931345 - Remove on OS X the Print Preview in AppMenu

Status: RESOLVED FIXED

(Thunderbird :: OS Integration, defect)

Description

[Richard Marti (:Paenglab)]

On OS X the print preview is in print dialog embedded and don't need a special menu item for it. The AppMenu has this item also on OS X.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: patch

Remove it on OS X

Comment 2

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 822729 [details] [diff] [review]
patch

Review of attachment 822729 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me!

Thanks,
Blake.

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 822729 [details] [diff] [review]
patch

[Approval Request Comment]
User impact if declined: The user has a dialog he don't need on OS X
Risk to taking this patch (and alternatives if risky): Low, it's only added a preprocessor rule to hide a menuentry on OS X

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 822729 [details] [diff] [review]
patch

Wrong approval flag chosen.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/0ae2fe7ca0a1

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 822729 [details] [diff] [review]
patch

[Triage Comment]
a=Standard8

Comment 7

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-aurora/rev/abaa064a70ad
https://hg.mozilla.org/releases/comm-beta/rev/1e1ac9ac584a

Comment 8

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-esr24/rev/19a3ea7aadce