931355 - Update See Also: whitelist for sourceforge.net new url format

Status: RESOLVED DUPLICATE of bug 919122

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Landry Breuil (:gaston)]

(Not sure that's the proper product/component)

While trying to add a See Also: entry on bug 931354, BMO rejected a perfectly valid sf.net bug url:

https://sourceforge.net/p/levent/bugs/320/ is not a valid URL to a bug. See Also URLs should point to one of: 
...
A bug on sourceforge.net.
...

Maybe a regex should be updated  somewhere in BMO's admin ?

Comment 1

[David Lawrence [:dkl]]

Upstream issue as the current code is looking for /tracker/ in the path and the URL you have pasted does not contain that so it does not consider it as a valid link.

dkl

Comment 2

[Landry Breuil (:gaston)]

I had a quick look at the source, and to me it seems Bugzilla/BugUrl/SourceForge.pm:should_handle() is where the fix should be applied. I dont have a full setup of bugzilla, but in pseudocode this could be:

# SourceForge tracker URLs have two forms:
#  http://sourceforge.net/tracker/?func=detail&aid=111&group_id=111&atid=111
#  https://sourceforge.net/p/levent/bugs/320/ 
return (lc($uri->authority) eq 'sourceforge.net'
       and ($uri->path =~ m|/bugs/|
       or  ($uri->path =~ m|/tracker/|
       and $uri->query_param('func') eq 'detail'
       and $uri->query_param('aid')
       and $uri->query_param('group_id')
       and $uri->query_param('atid'))) ? 1 : 0;
}

Comment 3

[rojanu]

Attachment: sfBugURL

Comment 4

[Andre Klapper]

Dup of bug 919122?

Comment 5

[Frédéric Buclin]

Comment on attachment 8341284 [details] [diff] [review]
sfBugURL

>=== modified file 'Bugzilla/BugUrl/SourceForge.pm'

>     #  http://sourceforge.net/tracker/?func=detail&aid=111&group_id=111&atid=111
>+    #  https://sourceforge.net/p/levent/bugs/320

With the 2nd syntax, the regexp must look for /p/*/bugs/d+, which takes no parameter.

Comment 6

[rojanu]

Attachment: sfBugURL v2

Fixed 2nd syntax to be more precise on URL

Comment 7

[Frédéric Buclin]

Comment on attachment 8341301 [details] [diff] [review]
sfBugURL v2

>+    #  https://sourceforge.net/p/levent/bugs/320

/bugs/ is not the single allowed path. I can find at least /tickets/ and /feature-requests/.

Comment 8

[Frédéric Buclin]

(In reply to Andre Klapper from comment #4)
> Dup of bug 919122?

Yes!