931359 - Add "People vouched by this person" to profiles

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Nikos Roussos [:comzeradd]]

It would be nice to have an easy way of viewing who vouched who.

On profile pages there should be a "Vouched by" and "Vouchees" area.

Comment 1

[Justin Crawford [:hoosteeno] [:jcrawford]]

Thanks for the bug!

This feature is in code review right now. I'll mark this one as a duplicate.

Comment 2

[Justin Crawford [:hoosteeno] [:jcrawford]]

Reopening for the second half of the request: Add "vouchees" to the profile. Vouchees means "people this person has vouched." 

This feature must apply the privacy settings of the field (full name) used to identify vouchees.

Suggested implementation:

Vouched For
Henry McVarnish
Sadie Des Moines
Lee Kim

Comment 3

[Jarek Śmiejczak [:jotes]]

Hi, if you wouldn't mind i would take this bug and finish whole issue to get more familiar with mozillians.org codebase.

Comment 4

[Giorgos Logiotatidis [:giorgos]]

Hi Jarek,

bharath already worked on this one (https://github.com/mozilla/mozillians/pull/689) and this is almost done. We have to make sure that privacy settings of the vouchees are respected, e.g. don't show vouchees with non-public profiles in the public profile of the voucher.

I originally said to bharath that I'm going to help finish this off but I've been unfortunately really busy to look at this. If bharath is also OK with that, I'm happy to assign this to you to build on top of his code.

Thanks for offering!

Comment 5

[Giorgos Logiotatidis [:giorgos]]

Jarek still interested in this bug? I'm happy to assign this to you to finish it.

Comment 6

[Jarek Śmiejczak [:jotes]]

:giorgos

Sure :)

Comment 7

[Giorgos Logiotatidis [:giorgos]]

It's all yours then! Make sure that you build upon bharath's work, no need to re-invent the wheel. :)


@bharath Thanks for your contribution on this bug! When you have the time to work on more bugs, please ping me. Happy to assign more to you.

Comment 8

[Giorgos Logiotatidis [:giorgos]]

@glogiotatidis sorry, but i'm currently a little to busy to continue work on this patch :( Please feel free to pass this issue for somebody else.
@jarekps :( Thanks for your work. Please come back when you have more time :)

This is very close to completiong. I'll wrap this up.

Thanks to both Bharath and Jarek

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/64a8c5e02be3a94c0897b16762ab166522185d38
[fix bug 931359] Display list of vouchees on profile page.

 * Display list of vouchees on profile respecting profile privacy of
   each vouchee
 * Cleanup h-card support
 * Add .profile-entry to tag each profile entry.

Credits for ideas and previous work to
 - https://mozillians.org/en-US/u/bharath/
 - https://mozillians.org/en-US/u/jarekps/

Comment 10

[Andrei [:sancus]]

Attachment: Screenshot of fixed bug

Comment 11

[Andrei [:sancus]]

VERIFIED on dev, screenshot above shows vouchees on the profile page.