931379 - Remove pinyin (simplified Chinese) selection from Developer > Keyboard layouts

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: screenshot of pinyin selection

Since pinyin input method has been implemented in v1.2
We need to remove this setting from 'Developer' section.

Comment 1

[Soumya Kanti Chakraborty]

I would like to work on it. Please assign on me.

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Hi Soumya,

Thanks for your interest in Firefox OS.
You could start with the following article if you have never worked on Gaia before,
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox_OS/Platform/Gaia/Hacking


And this patch would need we look at the the following file and the find out the corresponding section for that, and remove them!
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/elements/about_more_info_developer.html

--
Happy hacking!

Comment 3

[Soumya Kanti Chakraborty]

Attachment: Bug 931379 patch

Pull request for this bug

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 824523 [details] [review]
Bug 931379 patch

Looks good to me.
Redirect the review to a settings app peer. :)
Arthur, could you please help review this?

--
Soumya,

Thanks for the contribution.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 824523 [details] [review]
Bug 931379 patch

Soumya, thank you for taking the effort! r=me.

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: 7107b934993adc2894566ca11db956824b1c8031

Comment 7

[Soumya Kanti Chakraborty]

Thanks Arthur and Rudy for helping me, be a part of Gaia !

Comment 8

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 824523 [details] [review]
Bug 931379 patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Feature complete, so the developer section could be removed.
[User impact] if declined: May confuse user if this still exists.
[Testing completed]: Yes.
[Risk to taking this patch] (and alternatives if risky): Low, just removed html section.
[String changes made]: N/A.

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 7107b934993adc2894566ca11db956824b1c8031 to:
v1.2: 80992454ae73a518b366d9833ba01e97bd106705

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 7107b934993adc2894566ca11db956824b1c8031 to:
v1.3 already had this commit