Closed
Bug 931429
Opened 11 years ago
Closed 11 years ago
Fix PR_LOG compiling error for sandbox code on Linux
Categories
(Core :: Security, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
| Tracking | Status | |
|---|---|---|
| firefox28 | --- | fixed |
People
(Reporter: bbondy, Assigned: bbondy)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
817 bytes,
patch
|
kang
:
review+
|
Details | Diff | Splinter Review |
I tried compiling the sandbox code on linux but it runs into an error: /home/bbondy/projects/mozilla-central/security/sandbox/Sandbox.cpp:179:5: error: expected ‘;’ before string constant The problem is with PR_LOG, and we should be passing the varargs as one argument.
|
Assignee | |
Comment 1•11 years ago
|
||
For reference, this is how it should look: http://dxr.mozilla.org/mozilla-central/source/content/media/omx/OmxDecoder.cpp#l34
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #822849 -
Flags: review?(gdestuynder)
Attachment #822849 -
Flags: review?(gdestuynder) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/62afde5ed3c4
Target Milestone: --- → mozilla28
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/62afde5ed3c4
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
status-firefox28:
--- → fixed
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•