931452 - Checkbox focus artifact on Linux in the Shader Editor

Status: RESOLVED FIXED

(DevTools Graveyard :: WebGL Shader Editor, defect)

Description

[Victor Porof [:vporof][:vp]]

This is identical to bug 922119. That one got duped to bug 669507, and it doesn't matter anymore anyway because of bug 917072. But the shader editor still uses the old inlined eyeball approach, like the Style Editor. Fear not for I have a workaround.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: webgl-focus-workaround.patch

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 822875 [details] [diff] [review]
webgl-focus-workaround.patch

Review of attachment 822875 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/shared/widgets/widgets.css
@@ +24,5 @@
>    -moz-user-focus: normal;
>  }
>  
> +.side-menu-widget-group-checkbox .checkbox-label-box,
> +.side-menu-widget-item-checkbox .checkbox-label-box {

Is a descendant selector really necessary?

Comment 3

[Victor Porof [:vporof][:vp]]

(In reply to Panos Astithas [:past] from comment #2)
> Comment on attachment 822875 [details] [diff] [review]
> webgl-focus-workaround.patch
> 
> Review of attachment 822875 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/devtools/shared/widgets/widgets.css
> @@ +24,5 @@
> >    -moz-user-focus: normal;
> >  }
> >  
> > +.side-menu-widget-group-checkbox .checkbox-label-box,
> > +.side-menu-widget-item-checkbox .checkbox-label-box {
> 
> Is a descendant selector really necessary?

It's not a direct descendant, so that's partially true. I guess I could add the intermediate node and use direct descendant selectors. Will do, since it's a special case (Linux).

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/7d8d70f3a7c2