Closed Bug 931452 Opened 6 years ago Closed 6 years ago

Checkbox focus artifact on Linux in the Shader Editor

Categories

(DevTools Graveyard :: WebGL Shader Editor, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 27

People

(Reporter: vporof, Assigned: vporof)

References

Details

Attachments

(1 file)

This is identical to bug 922119. That one got duped to bug 669507, and it doesn't matter anymore anyway because of bug 917072. But the shader editor still uses the old inlined eyeball approach, like the Style Editor. Fear not for I have a workaround.
Blocks: 931463
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #822875 - Flags: review?(past)
Comment on attachment 822875 [details] [diff] [review]
webgl-focus-workaround.patch

Review of attachment 822875 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/shared/widgets/widgets.css
@@ +24,5 @@
>    -moz-user-focus: normal;
>  }
>  
> +.side-menu-widget-group-checkbox .checkbox-label-box,
> +.side-menu-widget-item-checkbox .checkbox-label-box {

Is a descendant selector really necessary?
Attachment #822875 - Flags: review?(past) → review+
(In reply to Panos Astithas [:past] from comment #2)
> Comment on attachment 822875 [details] [diff] [review]
> webgl-focus-workaround.patch
> 
> Review of attachment 822875 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/devtools/shared/widgets/widgets.css
> @@ +24,5 @@
> >    -moz-user-focus: normal;
> >  }
> >  
> > +.side-menu-widget-group-checkbox .checkbox-label-box,
> > +.side-menu-widget-item-checkbox .checkbox-label-box {
> 
> Is a descendant selector really necessary?

It's not a direct descendant, so that's partially true. I guess I could add the intermediate node and use direct descendant selectors. Will do, since it's a special case (Linux).
https://hg.mozilla.org/mozilla-central/rev/7d8d70f3a7c2
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.