931465 - "aOptions is undefined" from nsDOMIdentity.js

Status: RESOLVED FIXED

(Core Graveyard :: Identity, defect)

Description

[Jesse Ruderman]

Attachment: p-1.html

With:
  user_pref("dom.identity.enabled", true);

JavaScript error: resource://gre/components/nsDOMIdentity.js, line 140: aOptions is undefined

Comment 1

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Attachment: Make request() options default to {}

Comment 2

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Comment on attachment 8357426 [details] [diff] [review]
Make request() options default to {}

Thanks for your imprimatur, MattN!

Comment 3

[Matthew N. [:MattN]]

Comment on attachment 8357426 [details] [diff] [review]
Make request() options default to {}

Review of attachment 8357426 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/identity/nsDOMIdentity.js
@@ +128,5 @@
>      this._rpWatcher = aOptions;
>      this._identityInternal._mm.sendAsyncMessage("Identity:RP:Watch", message);
>    },
>  
>    request: function nsDOMIdentity_request(aOptions) {

You could do the following instead if this is only a problem with |undefined|:

 request: function nsDOMIdentity_request(aOptions = {}) {

Comment 4

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Good point.  That's nicer.

Thank you!

Comment 5

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Attachment: 931465-options-for-request

updated with cleaner syntax

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d2b783a56114

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d2b783a56114