931472 - Very long user name make things overlap

Status: RESOLVED WONTFIX

(bugzilla.mozilla.org Graveyard :: Sandstone/Mozilla Skin, defect)

Description

[Guilherme Lima]

Attachment: 917049 overlap.png

The problem can be seen on Bug 917049
I'm attaching a screenshot since the user might change the name.

Comment 3

[Kushagra Singh [:kushagra]]

Just faced this issue and from the comment https://bugzilla.mozilla.org/show_bug.cgi?id=947714#c1 i gather that this bug has already fixed.
If not, i suggest we fix the width of span(class="fn") and use CSS |text-overflow: ellipsis| property to hide the overflow and a |onmouseover| event to show the full user name.

Comment 4

[:glob ✱]

(In reply to Kushagra Singh [:kushagra] from comment #3)
> Just faced this issue and from the comment
> https://bugzilla.mozilla.org/show_bug.cgi?id=947714#c1 i gather that this
> bug has already fixed.

it hasn't - this is an issue specific to mozilla's sandstone skin.

> If not, i suggest we fix the width of span(class="fn") and use CSS
> |text-overflow: ellipsis| property to hide the overflow and a |onmouseover|
> event to show the full user name.

that sounds great.
note: we don't need the |onmouseover| because fn's parent container already has a tooltip with the full content.

Comment 5

[David Lawrence [:dkl]]

(In reply to Byron Jones ‹:glob› from comment #4)
> > If not, i suggest we fix the width of span(class="fn") and use CSS
> > |text-overflow: ellipsis| property to hide the overflow and a |onmouseover|
> > event to show the full user name.
> 
> that sounds great.
> note: we don't need the |onmouseover| because fn's parent container already
> has a tooltip with the full content.

What if we were to convert the current action links to a drop down similar to the arrow next to a user
name? We have (depending on perms) [edit][tag][reply][+|-], etc. that could be included in that menu. We
could do this as part of the Sandstone skin only I suppose. I was thinking of this very thing the other 
day that we should have a shortcut to mark a comment as spam using tags and did not want to add yet another
link to the action list.

dkl

Comment 6

[Kushagra Singh [:kushagra]]

(In reply to David Lawrence [:dkl] from comment #5)
> What if we were to convert the current action links to a drop down similar
> to the arrow next to a user
> name? We have (depending on perms) [edit][tag][reply][+|-], etc. that could
> be included in that menu. We
> could do this as part of the Sandstone skin only I suppose. I was thinking
> of this very thing the other 
> day that we should have a shortcut to mark a comment as spam using tags and
> did not want to add yet another
> link to the action list.
We can leave the Comment# button there and put the drop down button next to it.
And for implementing the spam functionality, if a comment is marked as spam then it will be automatically minimized when the page loads, just like what the [-] button performs. The Comment# button will also be crossed out to indicate that it is a spam. Though the "unspam" function should also be available. 

How does it sounds?

Plus, does a notification mail needs to be send out in case of a comment being marked spam?

Comment 7

[:glob ✱]

(In reply to David Lawrence [:dkl] from comment #5)
> What if we were to convert the current action links to a drop down similar
> to the arrow next to a user name?

i think that's a great idea, and i think it should happen upstream.  can you file a bug for that?
even with that feature we'll still need to truncate extremely long names where required (ie. it's a separate but related issue to this bug).

Comment 8

[:glob ✱]

(In reply to Kushagra Singh [:kushagra] from comment #6)
> Plus, does a notification mail needs to be send out in case of a comment
> being marked spam?

we don't send email notifications when a comment is tagged.

Comment 9

[Kushagra Singh [:kushagra]]

Filed the bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1000274

Comment 10

[Kushagra Singh [:kushagra]]

before I submit a patch, I would like you to take a look at this:
span.fn {
display: inline-block;
overflow: hidden;
text-overflow: ellipsis;
vertical-align: top;
max-width: 450px;
}

fixes the issue but in the top part of the page, assigned, reported by and attachment submitter's name all don't overflow and instead spawn off another line to accommodate the long user name. If this is an issue then I can try fixing their container's width else we can proceed with the current fix.

Comment 11

[:glob ✱]

(In reply to Kushagra Singh [:kushagra] Super long name for the Bug: 931472. Na Na Na Na Na.. Batman. from comment #10)
> fixes the issue but in the top part of the page, assigned, reported by and
> attachment submitter's name all don't overflow and instead spawn off another
> line to accommodate the long user name. If this is an issue then I can try
> fixing their container's width else we can proceed with the current fix.

we should only impact the display of the user name above the comment field (ie. use a more restrictive css selector instead of fixing other container widths).

Comment 15

[Kohei Yoshino [:kohei]]

I'm bulk-closing the remaining Sandstone skin bugs. Sandstone is no longer Mozilla's default style, and I'll be creating a new style guide for Bugzilla soon in Bug 1377977.